feat(record): add Treeland override to disable prelaunch splash#850
Merged
Conversation
- Add DConfig override JSON to disable prelaunch splash for deepin-screen-recorder - Use DTK6 dtk_install_dconfig mechanism with DCONFIG_OVERRIDE_FILES - Only enabled under Qt6 build to ensure Qt5 compatibility 新增 Treeland DConfig override JSON 文件,将 deepin-screen-recorder 的 enablePrelaunchSplash 设为 false,通过 DTK6 的 dtk_install_dconfig 机制安装,仅在 Qt6 构建环境下生效。 Log: 新增Treeland合成器下截图录屏应用预启动闪屏禁用配置 PMS: TASK-389563 Influence: 截图录屏应用在Treeland合成器下启动时不再显示预启动闪屏
deepin pr auto review你好!我是CodeGeeX。我已仔细审查了你提供的 Git Diff,该变更为 整体来看,这个改动目的明确,结构清晰,符合 DTK/DDE 生态的配置规范。不过,从语法逻辑、代码质量、性能和安全性角度,我仍有以下几点改进建议: 1. 语法与逻辑
2. 代码质量
3. 代码性能
4. 代码安全
改进后的代码建议1. 修改后的 # Treeland override: disable prelaunch splash
equals(QT_MAJOR_VERSION, 6) {
CONFIG += dtk_install_dconfig
# 提取公共路径,提升可维护性
TREELAND_DCONFIG_BASE = $$PWD/../assets/treeland/org.deepin.dde.treeland/org.deepin.dde.treeland.app
# 使用更具区分度的变量名
treeland_splash_override.files = $$TREELAND_DCONFIG_BASE/deepin-screen-recorder/90-disable-splash.json
treeland_splash_override.base = $$TREELAND_DCONFIG_BASE
treeland_splash_override.appid = org.deepin.dde.treeland
treeland_splash_override.meta_name = org.deepin.dde.treeland.app
DCONFIG_OVERRIDE_FILES += treeland_splash_override
}
INSTALLS += target icon desktop translations dbus_service manual_dir2. JSON 文件无需修改,保持原样即可。 但请再次确认被覆盖的原始默认值确实是 |
lzwind
approved these changes
May 28, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增 Treeland DConfig override JSON 文件,将 deepin-screen-recorder 的 enablePrelaunchSplash 设为 false,通过 DTK6 的 dtk_install_dconfig 机制安装,仅在 Qt6 构建环境下生效。
Log: 新增Treeland合成器下截图录屏应用预启动闪屏禁用配置
PMS: TASK-389563
Influence: 截图录屏应用在Treeland合成器下启动时不再显示预启动闪屏