Skip to content

feat: adapt to automatic rollback#119

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:featAuto
Jun 17, 2025
Merged

feat: adapt to automatic rollback#119
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:featAuto

Conversation

@mhduiy

@mhduiy mhduiy commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

When automatic rollback is enabled, no confirmation dialog box pops up

pms: TASK-377783

When automatic rollback is enabled, no confirmation dialog box pops up

pms: TASK-377783
@mhduiy mhduiy requested a review from 18202781743 June 16, 2025 10:33
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • ConfirmRollback 函数的返回类型从 void 更改为 QDBusPendingCall,这可能会影响调用该函数的代码,需要确认是否有相应的调用代码更新。
  • Manage::doConfirmRollback 函数中,QDBusPendingCallWatcher 的生命周期管理可能需要改进,以确保资源正确释放。
  • Manage::doConfirmRollback 函数中,exitApp() 调用应该在 QDBusPendingCallWatcherfinished 信号处理函数中,以确保在确认回滚操作完成后执行。

是否建议立即修改:

  • 确认 ConfirmRollback 函数的返回类型更改是否与调用代码兼容,并更新所有相关的调用。
  • 优化 QDBusPendingCallWatcher 的生命周期管理,确保资源正确释放。
  • 确保 exitApp() 调用在 QDBusPendingCallWatcherfinished 信号处理函数中,以避免潜在的竞态条件。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 0592146 into linuxdeepin:master Jun 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants