fix: improve update dialog UI and controls#128
Merged
Conversation
1. Added space between process title and percentage in UpdateControl for better readability 2. Increased dialog height in UpdateSelectDialog to accommodate content better 3. Replaced standard buttons with custom ButtonWithToolTip component that shows tooltips for truncated text 4. Removed redundant validation check in UpdateSetting's editingFinished handler 5. Improved layout and spacing in UpdateSelectDialog for better visual hierarchy fix: 改进更新对话框UI和控件 1. 在UpdateControl中添加进度标题和百分比之间的空格以提高可读性 2. 增加UpdateSelectDialog对话框高度以更好容纳内容 3. 使用自定义ButtonWithToolTip组件替换标准按钮,可显示截断文本的工具提示 4. 移除UpdateSetting中editingFinished处理程序中的冗余验证检查 5. 改进UpdateSelectDialog中的布局和间距以获得更好的视觉层次 pms: Bug-313015 pms: Bug-316113
mhduiy
approved these changes
Jun 20, 2025
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 改进更新对话框UI和控件
pms: Bug-313015
pms: Bug-316113