Skip to content

fix: improve update dialog UI and controls#128

Merged
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master
Jun 20, 2025
Merged

fix: improve update dialog UI and controls#128
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master

Conversation

@xionglinlin

Copy link
Copy Markdown
Contributor
  1. Added space between process title and percentage in UpdateControl for better readability
  2. Increased dialog height in UpdateSelectDialog to accommodate content better
  3. Replaced standard buttons with custom ButtonWithToolTip component that shows tooltips for truncated text
  4. Removed redundant validation check in UpdateSetting's editingFinished handler
  5. Improved layout and spacing in UpdateSelectDialog for better visual hierarchy

fix: 改进更新对话框UI和控件

  1. 在UpdateControl中添加进度标题和百分比之间的空格以提高可读性
  2. 增加UpdateSelectDialog对话框高度以更好容纳内容
  3. 使用自定义ButtonWithToolTip组件替换标准按钮,可显示截断文本的工具提示
  4. 移除UpdateSetting中editingFinished处理程序中的冗余验证检查
  5. 改进UpdateSelectDialog中的布局和间距以获得更好的视觉层次

pms: Bug-313015
pms: Bug-316113

1. Added space between process title and percentage in UpdateControl for
better readability
2. Increased dialog height in UpdateSelectDialog to accommodate content
better
3. Replaced standard buttons with custom ButtonWithToolTip component
that shows tooltips for truncated text
4. Removed redundant validation check in UpdateSetting's editingFinished
handler
5. Improved layout and spacing in UpdateSelectDialog for better visual
hierarchy

fix: 改进更新对话框UI和控件

1. 在UpdateControl中添加进度标题和百分比之间的空格以提高可读性
2. 增加UpdateSelectDialog对话框高度以更好容纳内容
3. 使用自定义ButtonWithToolTip组件替换标准按钮,可显示截断文本的工具提示
4. 移除UpdateSetting中editingFinished处理程序中的冗余验证检查
5. 改进UpdateSelectDialog中的布局和间距以获得更好的视觉层次

pms: Bug-313015
pms: Bug-316113
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • UpdateControl.qml中,text属性拼接时增加了空格,确保了文本显示的清晰度。
  • UpdateSelectDialog.qml中,调整了对话框的高度,并修改了按钮的布局和间距,提高了用户界面的美观性和可用性。
  • UpdateSelectDialog.qml中,新增了一个ButtonWithToolTip组件,用于为按钮添加工具提示功能,增强了用户体验。
  • UpdateSetting.qml中,移除了对lineEdit.showAlert属性的检查,简化了代码逻辑。

是否建议立即修改:

  • 是,建议立即修改,因为这些更改提高了代码的可读性、用户界面和用户体验。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin xionglinlin merged commit 478d382 into linuxdeepin:master Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants