fix(qml): fix button layout margin by adding right margin#281
Merged
deepin-bot[bot] merged 1 commit intoApr 21, 2026
Merged
Conversation
Add Layout.rightMargin: 8 to expand/collapse button for proper spacing. 为展开/折叠按钮添加 Layout.rightMargin: 8 以调整布局间距。 Log: 修复按钮布局边距 PMS: BUG-353875 Influence: 修复后按钮布局间距更合理,提升用户界面美观度和用户体验。
deepin pr auto review这段代码是一个 QML (Qt Modeling Language) 文件的差异片段,主要是在 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
综合改进建议虽然代码功能正确,但为了提高代码的可维护性和一致性,建议进行如下修改: 修改前: bottomPadding: 0
Layout.rightMargin: 8
font: D.DTK.fontManager.t8修改后(推荐): bottomPadding: 0
// 建议使用设计系统提供的标准间距常量,假设 DTK 或项目定义了 controlMargin
Layout.rightMargin: D.DTK.Theme.controlMargin // 或者项目定义的常量,如 AppConstants.smallSpacing
font: D.DTK.fontManager.t8总结: |
mhduiy
approved these changes
Apr 21, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Layout.rightMargin: 8 to expand/collapse button for proper spacing.
为展开/折叠按钮添加 Layout.rightMargin: 8 以调整布局间距。
Log: 修复按钮布局边距
PMS: BUG-353875
Influence: 修复后按钮布局间距更合理,提升用户界面美观度和用户体验。