fix: improve update checking mechanism and activation state#73
Merged
Conversation
deepin pr auto review代码审查意见:
总体来说,代码的改动是合理的,但需要注意确保所有相关的逻辑都得到了更新,并且测试这些改动以确保它们不会引入新的问题。 |
1. Changed default systemActivation state to true in UpdateModel for proper initialization 2. Added m_doCheckUpdates flag to prevent duplicate update checks 3. Modified update checking logic to use new activeUpdateModel signal instead of ActiveObjectChanged 4. Added count property and childrenChanged handler in update.qml to ensure proper timing for update checks 5. Simplified updateMain.qml to use direct signal connection for update checks The changes address several issues: - Prevents duplicate update checks when switching modules - Ensures update checks happen at the right time when entering the module - Improves initialization state management - Makes the update checking process more reliable and predictable fix: 改进更新检查机制和激活状态 1. 在UpdateModel中将默认systemActivation状态改为true以正确初始化 2. 添加m_doCheckUpdates标志防止重复检查更新 3. 修改更新检查逻辑,使用新的activeUpdateModel信号替代 ActiveObjectChanged 4. 在update.qml中添加count属性和childrenChanged处理程序以确保更新检查的 正确时机 5. 简化updateMain.qml,使用直接信号连接进行更新检查 这些更改解决了以下问题: - 防止切换模块时重复检查更新 - 确保进入模块时在正确时间检查更新 - 改进初始化状态管理 - 使更新检查过程更可靠和可预测 pms: Bug-316589
mhduiy
approved these changes
May 20, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes address several issues:
fix: 改进更新检查机制和激活状态
这些更改解决了以下问题:
pms: Bug-316589