Skip to content

fix: update privacy policy URL handling logic#75

Merged
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master
May 20, 2025
Merged

fix: update privacy policy URL handling logic#75
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master

Conversation

@xionglinlin

Copy link
Copy Markdown
Contributor
  1. Restructured privacy policy URL generation to handle community and commercial versions separately
  2. Simplified URL construction by removing region suffix for community version
  3. Added direct Chinese/English URLs for community version (deepin.org)
  4. Maintained existing region-based URLs for commercial version (uniontech.com)
  5. Improved code readability by removing redundant static lists and simplifying conditionals

The changes ensure proper privacy policy links are generated for different system types and regions, while making the code more maintainable and consistent with the actual privacy policy documentation locations.

fix: 更新隐私政策URL处理逻辑

  1. 重构隐私政策URL生成逻辑,区分社区版和商业版处理
  2. 简化社区版URL构造,不再使用区域后缀
  3. 为社区版添加直接的中文/英文URL(deepin.org)
  4. 商业版保持原有的基于区域的URL(uniontech.com)
  5. 通过移除冗余静态列表和简化条件判断提高代码可读性

这些修改确保为不同系统类型和区域生成正确的隐私政策链接,同时使代码更易于
维护并与实际隐私政策文档位置保持一致。

pms: Bug-317131

1. Restructured privacy policy URL generation to handle community and
commercial versions separately
2. Simplified URL construction by removing region suffix for community
version
3. Added direct Chinese/English URLs for community version (deepin.org)
4. Maintained existing region-based URLs for commercial version
(uniontech.com)
5. Improved code readability by removing redundant static lists and
simplifying conditionals

The changes ensure proper privacy policy links are generated for
different system types and regions, while making the code more
maintainable and consistent with the actual privacy policy documentation
locations.

fix: 更新隐私政策URL处理逻辑

1. 重构隐私政策URL生成逻辑,区分社区版和商业版处理
2. 简化社区版URL构造,不再使用区域后缀
3. 为社区版添加直接的中文/英文URL(deepin.org)
4. 商业版保持原有的基于区域的URL(uniontech.com)
5. 通过移除冗余静态列表和简化条件判断提高代码可读性

这些修改确保为不同系统类型和区域生成正确的隐私政策链接,同时使代码更易于
维护并与实际隐私政策文档位置保持一致。

pms: Bug-317131
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • qCWarning 更改为 qCDebug 可能会影响日志记录的严重性级别,需要确认是否为预期行为。
  • QString addr; 变量声明后未初始化,可能导致未定义行为。
  • QString communityRegion = "en"; 初始化后未使用,应移除或使用。
  • QStringList chineseRegion = { "cn", "hk", "tw" }; 列表中的 "ti" 和 "uy" 可能是拼写错误或未使用的区域代码。
  • addr 变量在 DCC_NAMESPACE::IsCommunitySystem 条件下被重新赋值,但未在 else 分支中赋值,可能导致空指针异常。
  • QString link = QString("<a style=\"text-decoration: none\" href=\"%1\">%2</a>").arg(addr).arg(tr("Privacy Policy"));addr 的拼接方式可能需要调整,以确保 URL 格式正确。

是否建议立即修改:

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin xionglinlin merged commit f49de5f into linuxdeepin:master May 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants