Skip to content

fix: enable clear button in download speed limit input#85

Merged
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master
May 23, 2025
Merged

fix: enable clear button in download speed limit input#85
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master

Conversation

@xionglinlin

Copy link
Copy Markdown
Contributor

Added clearButton.active property to show clear button only when input is focused and contains text

fix: 在下载速度限制输入中启用清除按钮

添加 clearButton.active 属性,仅在输入框获得焦点且包含文本时显示清除
按钮

Added clearButton.active property to show clear button only when
input is focused and contains text

fix: 在下载速度限制输入中启用清除按钮

 添加 clearButton.active 属性,仅在输入框获得焦点且包含文本时显示清除
按钮
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • clearButton.active属性中,使用了text.length !== 0来判断是否显示清除按钮,这是一个合理的逻辑,但需要确保clearButton对象在QML文件中已正确定义。

是否建议立即修改:

  • 否,这个改动看起来是合理的,没有明显的语法或逻辑错误。但是,建议确认clearButton对象是否已经在QML文件中定义,并且其属性设置正确。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin xionglinlin merged commit 2f5623b into linuxdeepin:master May 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants