chore: fix compilation warnings#90
Merged
Merged
Conversation
1. Added error handling for translation file loading in both main.cpp files 2. Removed redundant Qt::AA_UseHighDpiPixmaps attribute setting 3. Replaced DHiDPIHelper::loadNxPixmap with DIcon::loadNxPixmap for better compatibility chore: 修复编译警告 1. 在两个 main.cpp 文件中添加了翻译文件加载的错误处理 2. 移除了冗余的 Qt::AA_UseHighDpiPixmaps 属性设置 3. 使用 DIcon::loadNxPixmap 替代 DHiDPIHelper::loadNxPixmap 以获得更好的 兼容性
mhduiy
approved these changes
May 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: 修复编译警告