sync: from linuxdeepin/dtkdeclarative#265
Merged
Merged
Conversation
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideSynchronize Qt6 QML control sources from linuxdeepin/dtkdeclarative, enabling keyboard focus for CheckBox and RadioButton and updating the sync exclusion list. Class diagram for updated CheckBox and RadioButton QML componentsclassDiagram
class CheckBox {
+opacity
+D.DciIcon.mode
+D.DciIcon.theme
+focusPolicy: Qt.TabFocus
+indicator
}
class RadioButton {
+opacity
+D.DciIcon.mode
+D.DciIcon.theme
+focusPolicy: Qt.TabFocus
+icon
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#494
6e912c3 to
215a12f
Compare
Contributor
Author
deepin pr auto review代码审查意见如下: .syncexclude 文件
CheckBox.qml 文件
RadioButton.qml 文件
图标文件
通用建议
总体来说,这些更改看起来是为了提高用户交互体验和代码的一致性,但需要确保这些更改不会引入任何新的问题,并且已经通过了充分的测试。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#494
Summary by Sourcery
Synchronize source files from linuxdeepin/dtkdeclarative, adding keyboard focus support to checkbox and radio button QML components and aligning sync exclusions.
Enhancements:
Chores: