Skip to content

fix: make version parameter optional in release workflow#269

Merged
18202781743 merged 1 commit into
linuxdeepin:masterfrom
18202781743:dev-changelog
Jun 27, 2025
Merged

fix: make version parameter optional in release workflow#269
18202781743 merged 1 commit into
linuxdeepin:masterfrom
18202781743:dev-changelog

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 commented Jun 27, 2025

  1. Changed the 'version' parameter from required to optional in the
    GitHub Actions workflow
  2. This provides more flexibility when triggering releases
  3. Allows for cases where version might be determined programmatically
    or isn't needed
  4. Maintains backward compatibility while adding more workflow options

fix: 在发布工作流中将版本参数设为可选

  1. 将 GitHub Actions 工作流中的 'version' 参数从必填改为可选
  2. 这为触发发布提供了更大的灵活性
  3. 允许版本号通过程序确定或不需要版本号的情况
  4. 在添加更多工作流选项的同时保持向后兼容性

Summary by Sourcery

CI:

  • Make the version input optional in the GitHub Actions release workflow to allow greater flexibility and programmatic determination

1. Changed the 'version' parameter from required to optional in the
GitHub Actions workflow
2. This provides more flexibility when triggering releases
3. Allows for cases where version might be determined programmatically
or isn't needed
4. Maintains backward compatibility while adding more workflow options

fix: 在发布工作流中将版本参数设为可选

1. 将 GitHub Actions 工作流中的 'version' 参数从必填改为可选
2. 这为触发发布提供了更大的灵活性
3. 允许版本号通过程序确定或不需要版本号的情况
4. 在添加更多工作流选项的同时保持向后兼容性
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit b5b5d10 into linuxdeepin:master Jun 27, 2025
4 of 6 checks passed
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • 参数 versionrequired 属性从 true 改为 false,可能会影响自动发布流程的健壮性。

是否建议立即修改:

  • 是,需要确认这一更改是否符合业务逻辑需求。如果 version 参数是必须的,那么将其设置为 required: false 可能会导致流程在运行时出现错误。如果这一更改是有意为之,建议添加相应的错误处理逻辑,以确保流程的健壮性。

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 27, 2025

Reviewer's Guide

Updates the GitHub Actions release workflow to make the version parameter optional, enabling programmatic or omitted version releases while retaining backward compatibility.

File-Level Changes

Change Details Files
Made the workflow’s version input optional.
  • Removed “required: true” from the version parameter
  • Added “required: false” to the version parameter
.github/workflows/call-auto-release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants