Skip to content

sync: from linuxdeepin/dtkdeclarative #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Jun 18, 2025
Merged

sync: from linuxdeepin/dtkdeclarative #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion qt6/src/qml/FloatingPanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Control {
property int blurRadius: 64
// blur blurMultiplier
property real blurMultiplier: 0.0
property alias enableBlur: blur.valid

background: D.InWindowBlur {
id: blur
Expand All @@ -41,7 +42,7 @@ Control {

Loader {
anchors.fill: parent
active: Window.window && Window.window.color.a < 1
active: Window.window && Window.window.color.a < 1 && blur.valid
sourceComponent: D.ItemViewport {
Comment on lines 44 to 45

@sourcery-ai sourcery-ai Bot Jun 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Adding 'blur.valid' to the Loader's 'active' condition may prevent fallback rendering.

Requiring 'blur.valid' may cause the Loader to remain inactive when blur is unavailable, leading to missing UI elements. If you want to show a fallback when blur is invalid, handle that case separately.

anchors.fill: parent
fixed: true
Expand Down
1 change: 1 addition & 0 deletions qt6/src/qml/Menu.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ T.Menu {
backgroundColor: control.backgroundColor
backgroundNoBlurColor: control.backgroundNoBlurColor
outsideBorderColor: null
enableBlur: false // TODO disable blur temporarily, pms:BUG 300055
}
}

Expand Down
2 changes: 1 addition & 1 deletion qt6/src/qml/overridable/InWindowBlur.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Item {
property alias multiplier: blur.blurMultiplier
property alias content: blur
default property alias data: blitter.data
readonly property bool valid: blitter.blitterEnabled
property alias valid: blitter.blitterEnabled

D.BackdropBlitter {
id: blitter
Expand Down