fix: correct icon image update logic

[18202781743]

1. Changed from direct init() call to maybeUpdateUrl() when name is set
2. This ensures proper URL update handling when the icon name changes
3. Fixes potential cases where icon wouldn't update correctly after
   name change
4. Maintains consistency with the component's update behavior

fix: 修正图标图片更新逻辑

1. 将直接调用 init() 改为调用 maybeUpdateUrl() 当名称被设置时
2. 确保当图标名称改变时能正确处理URL更新
3. 修复了名称改变后图标可能无法正确更新的情况
4. 保持与组件更新行为的一致性

pms: BUG-311021

Summary by Sourcery

Bug Fixes:

• Use maybeUpdateUrl() instead of init() in DQuickIconImage::setName to ensure proper URL updates when the icon name changes.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 代码修改将 d->init(); 改为 d->maybeUpdateUrl();，需要确认这一改动是否符合功能需求。

是否建议立即修改:

• 否，但需要进一步确认 maybeUpdateUrl() 方法是否实现了 init() 方法所完成的功能。如果 maybeUpdateUrl() 已经包含了 init() 的所有逻辑，那么这个改动是合理的。如果 maybeUpdateUrl() 没有实现 init() 的所有逻辑，那么需要重新评估这个改动。

[sourcery-ai]

Hey @18202781743 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Reviewer's Guide

Replaced direct initialization with a conditional URL updater in the icon’s name setter to ensure the image source is refreshed correctly when the icon name changes, maintaining consistency with the component’s update behavior.

File-Level Changes

Change	Details	Files
Switch from init() to maybeUpdateUrl() in setName() for proper URL updates	Replaced direct init() call with maybeUpdateUrl() Guarded URL update on component completion Ensured icon image refresh after name change	src/private/dquickiconimage.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy, robertkill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment