Skip to content

fix: use applicationDisplayName instead of qAppName in DQMLGlobalObject #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 2 commits into from
May 15, 2025
Merged

fix: use applicationDisplayName instead of qAppName in DQMLGlobalObject #484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed603f
fix: use applicationDisplayName instead of qAppName in DQMLGlobalObject
18202781743 May 15, 2025
41ca888
Merge branch 'master' into master
18202781743 May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/private/dqmlglobalobject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ void DQMLGlobalObject::closeMessage(QObject *target, const QString &msgId)
void DQMLGlobalObject::sendSystemMessage(const QString &summary, const QString &body, const QString &appIcon, const QStringList &actions, const QVariantMap hints, const int timeout, const uint replaceId)
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Pass hints by const reference to avoid copying

Update the parameter to 'const QVariantMap& hints' to avoid unnecessary copies.

{
QDBusPendingCall reply = DTK_CORE_NAMESPACE::DUtil::DNotifySender(summary)
.appName(qAppName())
.appName(qApp->applicationDisplayName())
.appIcon(appIcon)
.appBody(body)
.actions(actions)
Expand Down
Loading