fix: correct arrow list view button behavior#507
Merged
Conversation
1. Changed `itemsView.atYEnd` to `view.atYEnd` to fix incorrect button enabling logic 2. Made `view` property required to ensure proper component initialization 3. The bug caused arrow buttons to remain enabled incorrectly when scrolling to the end of the list 4. Required property ensures view reference is always provided for proper functionality fix: 修复箭头列表视图按钮行为问题 1. 将 `itemsView.atYEnd` 改为 `view.atYEnd` 以修复按钮启用逻辑错误 2. 将 `view` 属性设为必需以确保组件正确初始化 3. 原错误导致滚动到列表末尾时箭头按钮仍错误地保持启用状态 4. 必需属性确保始终提供视图引用以保证功能正常
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 6, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#507
Contributor
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR ensures the ArrowListViewButton component behaves correctly by replacing the incorrect itemsView.atYEnd reference with view.atYEnd in the enabled binding and marking the view property as required for proper initialization. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
approved these changes
Aug 7, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itemsView.atYEndtoview.atYEndto fix incorrect buttonenabling logic
viewproperty required to ensure proper componentinitialization
scrolling to the end of the list
proper functionality
fix: 修复箭头列表视图按钮行为问题
itemsView.atYEnd改为view.atYEnd以修复按钮启用逻辑错误view属性设为必需以确保组件正确初始化Summary by Sourcery
Fix arrow list view button behavior by requiring the view reference and correcting end-of-list enabling logic
Bug Fixes:
Enhancements: