Skip to content

fix: correct arrow list view button behavior#507

Merged
18202781743 merged 1 commit into
linuxdeepin:masterfrom
18202781743:master
Aug 7, 2025
Merged

fix: correct arrow list view button behavior#507
18202781743 merged 1 commit into
linuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 commented Aug 6, 2025

  1. Changed itemsView.atYEnd to view.atYEnd to fix incorrect button
    enabling logic
  2. Made view property required to ensure proper component
    initialization
  3. The bug caused arrow buttons to remain enabled incorrectly when
    scrolling to the end of the list
  4. Required property ensures view reference is always provided for
    proper functionality

fix: 修复箭头列表视图按钮行为问题

  1. itemsView.atYEnd 改为 view.atYEnd 以修复按钮启用逻辑错误
  2. view 属性设为必需以确保组件正确初始化
  3. 原错误导致滚动到列表末尾时箭头按钮仍错误地保持启用状态
  4. 必需属性确保始终提供视图引用以保证功能正常

Summary by Sourcery

Fix arrow list view button behavior by requiring the view reference and correcting end-of-list enabling logic

Bug Fixes:

  • Correct the down arrow button enabling logic by using view.atYEnd instead of itemsView.atYEnd
  • Prevent arrow buttons from remaining enabled when scrolling to the end of the list

Enhancements:

  • Make the view property required to ensure proper component initialization

1. Changed `itemsView.atYEnd` to `view.atYEnd` to fix incorrect button
enabling logic
2. Made `view` property required to ensure proper component
initialization
3. The bug caused arrow buttons to remain enabled incorrectly when
scrolling to the end of the list
4. Required property ensures view reference is always provided for
proper functionality

fix: 修复箭头列表视图按钮行为问题

1. 将 `itemsView.atYEnd` 改为 `view.atYEnd` 以修复按钮启用逻辑错误
2. 将 `view` 属性设为必需以确保组件正确初始化
3. 原错误导致滚动到列表末尾时箭头按钮仍错误地保持启用状态
4. 必需属性确保始终提供视图引用以保证功能正常
@18202781743 18202781743 requested review from BLumia and mhduiy August 6, 2025 10:07
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 6, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#507
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • view属性从普通属性改为必需属性,确保在使用ArrowListViewButton时必须提供view

是否建议立即修改:

  • 是,因为这是一个属性变更,它可能会影响所有使用ArrowListViewButton的代码部分。需要确保所有相关代码都已经更新以适应这一变化,并且测试所有相关功能以确保没有引入新的错误。

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 6, 2025

Reviewer's Guide

This PR ensures the ArrowListViewButton component behaves correctly by replacing the incorrect itemsView.atYEnd reference with view.atYEnd in the enabled binding and marking the view property as required for proper initialization.

File-Level Changes

Change Details Files
Fix arrow button enabling logic
  • Replace itemsView.atYEnd with view.atYEnd in the enabled binding
  • Preserve atYBeginning check for UpButton
qt6/src/qml/private/ArrowListViewButton.qml
Enforce required view property
  • Convert property Item view to required property Item view
qt6/src/qml/private/ArrowListViewButton.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit d82f576 into linuxdeepin:master Aug 7, 2025
19 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants