feat: update control styles to DTK 25 specifications#535
Conversation
Updated multiple control styling properties to align with DTK 25 design specifications: 1. Changed control radius from 8 to 6 for more modern appearance 2. Reduced button height from 36 to 30 for compact layout 3. Updated comboBox height from 36 to 30 for consistency 4. Adjusted dialogWindow content horizontal margin from 10 to 6 for better spacing These changes ensure visual consistency with the latest DTK 25 design system and improve the overall user interface aesthetics. Log: Updated control styling to match DTK 25 design standards Influence: 1. Verify button appearance and layout in various states 2. Test comboBox dropdown functionality and visual alignment 3. Check dialog window content spacing and margins 4. Validate overall UI consistency across different controls 5. Test responsive behavior with updated dimensions feat: 更新控件样式以符合 DTK 25 规范 更新多个控件样式属性以符合 DTK 25 设计规范: 1. 将控件圆角从 8 改为 6,实现更现代的外观 2. 将按钮高度从 36 减少到 30,实现更紧凑的布局 3. 将组合框高度从 36 更新为 30,保持一致性 4. 将对话框窗口内容水平边距从 10 调整为 6,优化间距 这些更改确保与最新的 DTK 25 设计系统保持视觉一致性,并改善整体用户界面美 观度。 Log: 更新控件样式以符合 DTK 25 设计标准 Influence: 1. 验证各种状态下按钮的外观和布局 2. 测试组合框下拉功能和视觉对齐 3. 检查对话框窗口内容间距和边距 4. 验证不同控件之间的整体 UI 一致性 5. 测试更新尺寸后的响应行为
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#535
deepin pr auto review我来审查这个git diff,这是一个关于Qt6 QML样式文件的变更,主要涉及一些UI尺寸参数的调整。以下是详细的分析和建议: 1. 语法逻辑分析
2. 代码质量分析
3. 代码性能影响
4. 代码安全性分析
5. 改进建议5.1 一致性考虑
5.2 响应式设计考虑
5.3 可维护性建议
5.4 具体修改建议
6. 测试建议
总体而言,这些修改主要是UI尺寸的微调,不会引入严重问题,但建议进行充分的UI测试以确保视觉效果和用户体验不受影响。 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates key styling parameters in FlowStyle.qml to align with DTK 25 design specifications by adjusting control radius, element heights, and dialog margins. Class diagram for updated FlowStyle control propertiesclassDiagram
class FlowStyle {
+control: QtObject
+button: QtObject
+comboBox: QtObject
+dialogWindow: QtObject
}
class control {
+radius: int
+spacing: int
+padding: int
+borderWidth: int
}
class button {
+width: int
+height: int
+hPadding: int
+vPadding: float
+iconSize: int
}
class comboBox {
+width: int
+height: int
+padding: int
+spacing: int
+iconSize: int
}
class dialogWindow {
+width: int
+height: int
+contentHMargin: int
+footerMargin: int
+titleBarHeight: int
+iconSize: int
}
FlowStyle --> control
FlowStyle --> button
FlowStyle --> comboBox
FlowStyle --> dialogWindow
%% Highlight updated properties
control : radius = 6
button : height = 30
comboBox : height = 30
dialogWindow : contentHMargin = 6
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider extracting repeated numeric style values (e.g., radius, heights, margins) into named constants or design tokens to simplify future DTK spec updates.
- Ensure the reduced control heights still meet accessibility and touch-target size guidelines to avoid potential text clipping or usability issues.
- Verify that other related components (such as input fields or panels) have been updated for consistent radius and padding to fully align with DTK 25 specifications.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting repeated numeric style values (e.g., radius, heights, margins) into named constants or design tokens to simplify future DTK spec updates.
- Ensure the reduced control heights still meet accessibility and touch-target size guidelines to avoid potential text clipping or usability issues.
- Verify that other related components (such as input fields or panels) have been updated for consistent radius and padding to fully align with DTK 25 specifications.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
dtk25还是统一全部一起改吧,单独改一两个控件比较割裂,暂不考虑合并此pr |
Updated multiple control styling properties to align with DTK 25 design specifications:
These changes ensure visual consistency with the latest DTK 25 design system and improve the overall user interface aesthetics.
Log: Updated control styling to match DTK 25 design standards
Influence:
feat: 更新控件样式以符合 DTK 25 规范
更新多个控件样式属性以符合 DTK 25 设计规范:
这些更改确保与最新的 DTK 25 设计系统保持视觉一致性,并改善整体用户界面美
观度。
Log: 更新控件样式以符合 DTK 25 设计标准
Influence:
Summary by Sourcery
Update control styling to align with DTK 25 design specifications
Enhancements: