Skip to content

fix: add missing prefix for QTranslator::load()#320

Merged
BLumia merged 1 commit intolinuxdeepin:masterfrom
BLumia:missing-prefix
Jun 6, 2025
Merged

fix: add missing prefix for QTranslator::load()#320
BLumia merged 1 commit intolinuxdeepin:masterfrom
BLumia:missing-prefix

Conversation

@BLumia
Copy link
Copy Markdown
Member

@BLumia BLumia commented Jun 6, 2025

No description provided.

@BLumia BLumia requested a review from 18202781743 June 6, 2025 10:09
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • 代码修改中,QTranslator::load函数的第三个参数从空字符串变为QString('_'),这可能是为了在加载翻译文件时指定特定的文件命名约定。

是否建议立即修改:

  • 否,这个修改看起来是有意为之的,以适应特定的翻译文件命名规则。但是,需要确保这个修改不会影响现有的翻译文件加载逻辑,并且所有相关的翻译文件都遵循新的命名约定。
  • 是,建议添加注释来解释为什么需要这个修改,以及这个修改对整个系统的影响。这有助于其他开发者理解这个变更的背景和目的。
  • 是,建议进行全面的测试,确保修改后的代码能够正确加载所有预期的翻译文件,并且不会引入新的错误。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jun 6, 2025
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#320
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/kernel/dguiapplicationhelper.cpp": [
        {
            "line": "    QString socket_key = \"_d_dtk_single_instance_\";",
            "line_number": 1469,
            "rule": "S106",
            "reason": "Var naming | 2ad926d35b"
        }
    ]
}

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 44bed9e into linuxdeepin:master Jun 6, 2025
20 of 24 checks passed
BLumia pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Jun 6, 2025
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants