Skip to content

feat: Support VERSION file#322

Merged
zccrs merged 2 commits intolinuxdeepin:masterfrom
asterwyx:version
Jun 11, 2025
Merged

feat: Support VERSION file#322
zccrs merged 2 commits intolinuxdeepin:masterfrom
asterwyx:version

Conversation

@asterwyx
Copy link
Copy Markdown
Contributor

@asterwyx asterwyx commented Jun 9, 2025

Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang wangyixue@deepin.org

asterwyx added 2 commits June 9, 2025 14:08
Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang <wangyixue@deepin.org>
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • .github/workflows/call-auto-release.yml文件中,workflow_dispatchworkflow_call的输入参数定义重复,可以提取为一个公共部分以提高代码复用性。
  • CMakeLists.txt文件中,使用file(READ)读取VERSION文件并去除首尾空白字符,这是一个合理的做法,但需要确保VERSION文件的存在和格式正确。

是否建议立即修改:

  • 是,建议立即修改重复的输入参数定义,以提高代码的可维护性。
  • 是,建议添加对VERSION文件存在性和格式的检查,以避免运行时错误。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jun 9, 2025
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#322
@asterwyx asterwyx requested a review from zccrs June 9, 2025 06:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkgui\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | 4393cea435"
        }
    ]
}

@asterwyx asterwyx requested a review from 18202781743 June 9, 2025 06:12
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit f834cb5 into linuxdeepin:master Jun 11, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants