Skip to content

fix: make version parameter optional in release workflow#326

Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Jun 27, 2025
Merged

fix: make version parameter optional in release workflow#326
mhduiy merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

  1. Changed version parameter from required to optional in GitHub
    workflow
  2. Fixed spec file formatting by aligning Version and Release fields
  3. Added %{?dist} macro to Release field for proper RPM building

The changes make the release workflow more flexible by allowing version-
less releases while maintaining proper RPM spec file formatting and
distribution tagging. This helps with automated release processes and
ensures consistent package building across different distributions.

fix: 在发布工作流中使版本参数可选

  1. 将 GitHub 工作流中的版本参数从必填改为可选
  2. 修复 spec 文件格式,对齐 Version 和 Release 字段
  3. 在 Release 字段添加 %{?dist} 宏以支持正确的 RPM 构建

这些变更使发布工作流更加灵活,允许无版本号的发布,同时保持 RPM spec 文件
的正确格式和分发标签。这有助于自动化发布流程并确保在不同发行版上一致的软
件包构建。

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

代码审查意见:

  1. .github/workflows/call-auto-release.yml 文件修改:

    • version 参数的 required 属性从 true 改为 false 可能会影响自动发布流程,因为版本号是发布流程中非常重要的信息。建议确认这一改动是否符合业务逻辑需求,并确保在不需要版本号的情况下,流程仍然能够正常工作。
  2. rpm/dtkgui.spec 文件修改:

    • Release 字段中添加了 %{?dist},这是一个好的做法,因为它允许根据不同的发行版生成不同的 RPM 包版本。这个改动是合理的,没有发现明显的语法或逻辑错误。

总体来说,这两个改动都是合理的,但需要确保它们不会对现有的发布流程造成负面影响。如果 version 参数的 required 属性被修改,建议添加相应的文档说明,并确保所有相关开发者和用户都了解这一变化。

1. Changed version parameter from required to optional in GitHub
workflow
2. Fixed spec file formatting by aligning Version and Release fields
3. Added %{?dist} macro to Release field for proper RPM building

The changes make the release workflow more flexible by allowing version-
less releases while maintaining proper RPM spec file formatting and
distribution tagging. This helps with automated release processes and
ensures consistent package building across different distributions.

fix: 在发布工作流中使版本参数可选

1. 将 GitHub 工作流中的版本参数从必填改为可选
2. 修复 spec 文件格式,对齐 Version 和 Release 字段
3. 在 Release 字段添加 %{?dist} 宏以支持正确的 RPM 构建

这些变更使发布工作流更加灵活,允许无版本号的发布,同时保持 RPM spec 文件
的正确格式和分发标签。这有助于自动化发布流程并确保在不同发行版上一致的软
件包构建。
@mhduiy mhduiy merged commit 9e54cbf into linuxdeepin:master Jun 27, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants