Skip to content

refactor: remove deprecated QRegExp, fix typos, replace Q_FOREACH wit…#741

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

refactor: remove deprecated QRegExp, fix typos, replace Q_FOREACH wit…#741
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 12, 2026

…h range-based for

  • dshortcutedit.cpp: remove dead commented-out code containing deprecated QRegExp
  • dtitlebar.cpp: fix "batter salution" → "better solution", rename private method isVisableOnFullscreen → isVisibleOnFullscreen
  • dapplication.cpp: fix "effoct" → "effect" in comment
  • Replace Q_FOREACH with C++17 range-based for loops in: dblureffectwidget.cpp, dsegmentedcontrol.cpp, dcrumbedit.cpp, dexpandgroup.cpp, dprintpreviewdialog.cpp, ddrawergroup.cpp, dprintpreviewwidget.cpp

Log: Modernize deprecated Qt patterns and fix typos

Agent-Logs-Url: https://github.com/doniyor14/dtkwidget/sessions/b415c6ef-8e7c-4ed1-a3c1-e2c51b65763e

…h range-based for

- dshortcutedit.cpp: remove dead commented-out code containing deprecated QRegExp
- dtitlebar.cpp: fix "batter salution" → "better solution", rename private
  method isVisableOnFullscreen → isVisibleOnFullscreen
- dapplication.cpp: fix "effoct" → "effect" in comment
- Replace Q_FOREACH with C++17 range-based for loops in:
  dblureffectwidget.cpp, dsegmentedcontrol.cpp, dcrumbedit.cpp,
  dexpandgroup.cpp, dprintpreviewdialog.cpp, ddrawergroup.cpp,
  dprintpreviewwidget.cpp

Log: Modernize deprecated Qt patterns and fix typos

Agent-Logs-Url: https://github.com/doniyor14/dtkwidget/sessions/b415c6ef-8e7c-4ed1-a3c1-e2c51b65763e

Co-authored-by: doniyor14 <93820731+doniyor14@users.noreply.github.com>
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: doniyor14

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

Hi @doniyor14. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

Hi @doniyor14. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost closed this by deleting the head repository Apr 14, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants