Skip to content

fix(config): bump serial for dsettings keys after global flags removal#445

Merged
qiuzhiqian merged 1 commit into
masterfrom
fix-dconfig-serial
Jul 2, 2026
Merged

fix(config): bump serial for dsettings keys after global flags removal#445
qiuzhiqian merged 1 commit into
masterfrom
fix-dconfig-serial

Conversation

@qiuzhiqian

@qiuzhiqian qiuzhiqian commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Increment the serial of the 22 keys whose "flags": ["global"] entries were removed in 981a6e8 so dsettings recognizes the configuration change (use-dsettings, version, system-sources, delivery limit keys, etc.).

Bug: https://pms.uniontech.com/bug-view-368375.html

Summary by Sourcery

Bug Fixes:

  • Ensure dsettings picks up configuration changes for keys whose global flags were removed by incrementing their serial values.

Increment the serial of the 22 keys whose "flags": ["global"] entries
were removed in 981a6e8 so dsettings recognizes the configuration
change (use-dsettings, version, system-sources, delivery limit keys,
etc.).

Bug: https://pms.uniontech.com/bug-view-368375.html
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot:
提交邮箱中包含我们的合作伙伴,但您似乎并非合作伙伴的成员或对接人,请联系相关对接人将您添加至组织之中,或由其重新发起 Pull Request。
The commit email domain belongs to one of our partners, but it seems you are not yet a member of the current organization, please contact the contact person to add you to the organization or let them submit the Pull Request.

xml seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@sourcery-ai

sourcery-ai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the dsettings configuration so that keys whose global flags were removed in an earlier change are recognized as modified by bumping their serial values in the org.deepin.dde.lastore JSON config.

File-Level Changes

Change Details Files
Bump dsettings serial values for keys whose global flags were previously removed so configuration changes are picked up correctly.
  • Increment the serial field for each of the 22 affected configuration keys so dsettings treats them as updated
  • Ensure all modified keys correspond to those that had their "flags": ["global"] entries removed in commit 981a6e8 (e.g., use-dsettings, version, system-sources, delivery limit related keys)
  • Keep all other configuration fields and structure intact, changing only the serial values
usr/share/dsg/configs/org.deepin.dde.lastore/org.deepin.dde.lastore.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qiuzhiqian, zhaohuiw42

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码正确实现了DSettings配置项的版本号递增,无任何安全与逻辑缺陷
逻辑完全正确且符合DSG架构规范,不扣分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

JSON格式修改准确,所有配置项的serial字段从0变更为1,符合DSettings守护进程的版本控制与变更感知机制
潜在问题:无
建议:保持现有修改方式

  • 2.代码质量(良好)✓

配置文件的修改目标明确,全量修改避免了遗漏,符合系统升级后强制触发配置变更信号覆盖客户端本地旧缓存数据的业务需求
潜在问题:无
建议:无

  • 3.代码性能(无性能问题)✓

静态JSON配置文件的数值变更对解析性能无任何影响,整数0和1的解析开销完全一致
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
纯静态配置文件版本号递增,不涉及命令注入、路径遍历、权限绕过等安全风险面

  • 建议:无需额外安全修复

■ 【改进建议代码示例】

--- a/usr/share/dsg/configs/org.deepin.dde.lastore/org.deepin.dde.lastore.json
+++ b/usr/share/dsg/configs/org.deepin.dde.lastore/org.deepin.dde.lastore.json
@@ -4,7 +4,7 @@
   "contents": {
     "use-dsettings": {
       "value": false,
-      "serial": 0,
+      "serial": 1,
       "name": "UseDSettings",
       "description": "",
       "permissions": "readwrite",

@qiuzhiqian qiuzhiqian merged commit 2418992 into master Jul 2, 2026
25 of 31 checks passed
@qiuzhiqian qiuzhiqian deleted the fix-dconfig-serial branch July 2, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants