Skip to content

fix: reset backup status before update source check#196

Merged
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master
Jul 17, 2025
Merged

fix: reset backup status before update source check#196
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:master

Conversation

@xionglinlin

@xionglinlin xionglinlin commented Jul 16, 2025

Copy link
Copy Markdown
Contributor
  1. Added pre-hook to reset ABStatus before update source check
  2. Specifically sets status to AllCheckUpdate, NotBackup, NoABError
  3. Fixes issue where failed backup state would incorrectly persist during subsequent update checks
  4. Ensures clean state for new update operations

fix: 在更新源检查前重置备份状态

  1. 添加前置钩子在更新源检查前重置 ABStatus
  2. 明确将状态设置为 AllCheckUpdate, NotBackup, NoABError
  3. 修复了备份失败状态会在后续更新检查中错误保留的问题
  4. 确保新更新操作处于干净状态

pms: Bug-323831

1. Added pre-hook to reset ABStatus before update source check
2. Specifically sets status to AllCheckUpdate, NotBackup, NoABError
3. Fixes issue where failed backup state would incorrectly persist
during subsequent update checks
4. Ensures clean state for new update operations

fix: 在更新源检查前重置备份状态

1. 添加前置钩子在更新源检查前重置 ABStatus
2. 明确将状态设置为 AllCheckUpdate, NotBackup, NoABError
3. 修复了备份失败状态会在后续更新检查中错误保留的问题
4. 确保新更新操作处于干净状态

pms: Bug-323831
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • 在新增的 PreHooks 函数中,直接修改了 m.statusManager 的状态,可能会影响其他依赖于该状态的逻辑,建议确认是否有必要在 PreHooks 中进行状态修改。
  • 新增的 PreHooks 函数没有错误处理,如果 m.statusManager.SetABStatus 失败,应该有相应的错误处理机制。

是否建议立即修改:

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, KT-lcz, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin xionglinlin merged commit 7673e0f into linuxdeepin:master Jul 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants