fix: Solve the issue where "lastore-apt-clean" outputs warning messages#249
Merged
Conversation
Description: A file is detected missing during the initialization of the config Log: Use the dde-dconfig command to retrieve configuration values Bug: https://pms.uniontech.com/bug-view-338213.html Influence: Command output
51279ac to
7baa938
Compare
deepin pr auto review我来对这个代码变更进行审查:
// 定义常量
const ConfigPath = "/var/lib/lastore/config.json"
// 提取公共函数
func getCleanCommandArgs() []string {
args := []string{"-print-json"}
if NewConfig(ConfigPath).IncrementalUpdate {
args = append(args, "--incremental-update")
}
return args
}
// 改进后的函数
func getArchiveInfo() (string, error) {
out, err := exec.Command("/usr/bin/lastore-apt-clean", getCleanCommandArgs()...).Output()
if err != nil {
return "", err
}
return string(out), nil
}
func getNeedCleanCacheSize() (float64, error) {
output, err := exec.Command("/usr/bin/lastore-apt-clean", getCleanCommandArgs()...).Output()
if err != nil {
return 0, err
}
// 其余处理逻辑...
}
这些改进可以提高代码的可维护性、可读性和健壮性。 |
qiuzhiqian
approved these changes
Oct 31, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fire-dtx, qiuzhiqian The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: A file is detected missing during the initialization of the config
Log: Use the dde-dconfig command to retrieve configuration values
Bug: https://pms.uniontech.com/bug-view-338213.html
Influence: Command output