feat: finalize deployment during first check#277
Conversation
Move osTreeFinalize into the first-check success path so finalize happens before a potential reboot prior to login. Task: https://pms.uniontech.com/task-view-385219.html
|
CLA Assistant Lite bot: |
deepin pr auto review我来对这段代码的变更进行审查:
a) 代码结构和可读性:
b) 代码逻辑:
c) 代码安全性:
case firstCheck:
if err := m.immutableManager.osTreeFinalize(); err != nil {
logger.Warningf("Failed to finalize os tree after first check: %v", err)
}
case secondCheck:
// 登录后检查无异常,上报更新成功,更新baseline信息,还原grub配置
if err := m.delRebootCheckOption(secondCheck); err != nil {
logger.Warningf("Failed to delete reboot check option: %v", err)
}
这个变更的意图是合理的,但代码实现上还可以进一步优化,特别是在错误处理和日志记录方面。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: electricface, zhaohuiw42 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Move osTreeFinalize into the first-check success path so finalize happens before a potential reboot prior to login.
Task: https://pms.uniontech.com/task-view-385219.html