Skip to content

perf: cache resolved indexed directories to avoid repeated resolution #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johnson-zs merged 1 commit into from
May 21, 2026
+5 −5
Merged

perf: cache resolved indexed directories to avoid repeated resolution #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/dfm-search/dfm-search-lib/utils/searchutility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ QStringList defaultContentSearchExtensions()

QStringList defaultIndexedDirectory()
{
const QStringList &dirs = getResolvedIndexedDirectories();
static const QStringList dirs = getResolvedIndexedDirectories();

if (dirs.isEmpty()) {
return QStringList();
Expand Down Expand Up @@ -615,7 +615,7 @@ bool isPathInContentIndexDirectory(const QString &path)
if (!isContentIndexAvailable())
return false;

static const QStringList &kDirs = DFMSEARCH::Global::defaultIndexedDirectory();
static const QStringList kDirs = DFMSEARCH::Global::defaultIndexedDirectory();
return isPathInAnyDirectory(path, kDirs);
}

Expand Down Expand Up @@ -673,7 +673,7 @@ bool isPathInOcrTextIndexDirectory(const QString &path)
if (!isOcrTextIndexAvailable())
return false;

static const QStringList &kDirs = DFMSEARCH::Global::defaultIndexedDirectory();
static const QStringList kDirs = DFMSEARCH::Global::defaultIndexedDirectory();
return isPathInAnyDirectory(path, kDirs);
}

Expand Down Expand Up @@ -714,11 +714,11 @@ bool isPathInFileNameIndexDirectory(const QString &path)
if (!isFileNameIndexDirectoryAvailable())
return false;

static const QStringList &kBlackPaths = defaultBlacklistPaths();
static const QStringList kBlackPaths = defaultBlacklistPaths();
if (BlacklistMatcher::isPathBlacklisted(path, kBlackPaths))
return false;

static const QStringList &kIndexedDirs = DFMSEARCH::Global::defaultIndexedDirectory();
static const QStringList kIndexedDirs = DFMSEARCH::Global::defaultIndexedDirectory();
return isPathInAnyDirectory(path, kIndexedDirs);
}

Expand Down
Loading