|
| 1 | +import { afterEach, describe, expect, it, vi } from 'vitest' |
| 2 | + |
| 3 | +import { fetchDockerhub } from '../fetchDockerhub' |
| 4 | +import { FetchError } from '../types' |
| 5 | + |
| 6 | +const BASE = 'https://hub.docker.com/v2' |
| 7 | + |
| 8 | +function mockFetch(status: number, body: unknown, headers: Record<string, string> = {}) { |
| 9 | + return vi.spyOn(globalThis, 'fetch').mockResolvedValue( |
| 10 | + new Response(typeof body === 'string' ? body : JSON.stringify(body), { |
| 11 | + status, |
| 12 | + headers: { 'Content-Type': 'application/json', ...headers }, |
| 13 | + }), |
| 14 | + ) |
| 15 | +} |
| 16 | + |
| 17 | +afterEach(() => { |
| 18 | + vi.restoreAllMocks() |
| 19 | +}) |
| 20 | + |
| 21 | +describe('fetchDockerhub', () => { |
| 22 | + it('returns pull/star counts on 200', async () => { |
| 23 | + mockFetch(200, { |
| 24 | + name: 'grafana', |
| 25 | + namespace: 'grafana', |
| 26 | + pull_count: 12345, |
| 27 | + star_count: 678, |
| 28 | + last_updated: '2026-05-01T00:00:00Z', |
| 29 | + }) |
| 30 | + |
| 31 | + const r = await fetchDockerhub(BASE, 'grafana/grafana') |
| 32 | + expect(r).toEqual({ |
| 33 | + imageName: 'grafana/grafana', |
| 34 | + pulls: 12345, |
| 35 | + stars: 678, |
| 36 | + lastUpdated: '2026-05-01T00:00:00Z', |
| 37 | + }) |
| 38 | + }) |
| 39 | + |
| 40 | + it('appends trailing slash to the request URL', async () => { |
| 41 | + const spy = mockFetch(200, { pull_count: 1, star_count: 0 }) |
| 42 | + await fetchDockerhub(BASE, 'a/b') |
| 43 | + expect(spy).toHaveBeenCalledWith(`${BASE}/repositories/a/b/`, expect.anything()) |
| 44 | + }) |
| 45 | + |
| 46 | + it('normalizes a trailing slash on the configured base URL', async () => { |
| 47 | + const spy = mockFetch(200, { pull_count: 1, star_count: 0 }) |
| 48 | + await fetchDockerhub(`${BASE}/`, 'a/b') |
| 49 | + expect(spy).toHaveBeenCalledWith(`${BASE}/repositories/a/b/`, expect.anything()) |
| 50 | + }) |
| 51 | + |
| 52 | + it('classifies 404 as NOT_FOUND', async () => { |
| 53 | + mockFetch(404, { message: 'object not found' }) |
| 54 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'NOT_FOUND' }) |
| 55 | + }) |
| 56 | + |
| 57 | + it('classifies 400 as NOT_FOUND (Hub 400s on malformed slugs)', async () => { |
| 58 | + mockFetch(400, { message: 'bad request' }) |
| 59 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'NOT_FOUND' }) |
| 60 | + }) |
| 61 | + |
| 62 | + it('classifies 429 as RATE_LIMIT with resetAt from header', async () => { |
| 63 | + const resetSec = Math.floor(Date.now() / 1000) + 120 |
| 64 | + mockFetch(429, { message: 'too many' }, { 'x-ratelimit-reset': String(resetSec) }) |
| 65 | + |
| 66 | + expect.assertions(3) |
| 67 | + try { |
| 68 | + await fetchDockerhub(BASE, 'a/b') |
| 69 | + } catch (err) { |
| 70 | + expect(err).toBeInstanceOf(FetchError) |
| 71 | + const fe = err as FetchError |
| 72 | + expect(fe.kind).toBe('RATE_LIMIT') |
| 73 | + expect(fe.resetAt).toBeGreaterThan(Date.now()) |
| 74 | + } |
| 75 | + }) |
| 76 | + |
| 77 | + it('does NOT discard a 200 response when x-ratelimit-remaining is 0', async () => { |
| 78 | + // remaining=0 means this request consumed the last slot; the response itself |
| 79 | + // is valid. The next call will 429 and park then. |
| 80 | + mockFetch(200, { pull_count: 1, star_count: 0 }, { 'x-ratelimit-remaining': '0' }) |
| 81 | + const r = await fetchDockerhub(BASE, 'a/b') |
| 82 | + expect(r.pulls).toBe(1) |
| 83 | + }) |
| 84 | + |
| 85 | + it('classifies 401/403 as AUTH so misconfig surfaces instead of looking like a miss', async () => { |
| 86 | + mockFetch(401, { message: 'unauthorized' }) |
| 87 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'AUTH' }) |
| 88 | + mockFetch(403, { message: 'forbidden' }) |
| 89 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'AUTH' }) |
| 90 | + }) |
| 91 | + |
| 92 | + it('classifies 5xx as TRANSIENT', async () => { |
| 93 | + mockFetch(503, 'Service Unavailable') |
| 94 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'TRANSIENT' }) |
| 95 | + }) |
| 96 | + |
| 97 | + it('classifies network failure as TRANSIENT', async () => { |
| 98 | + vi.spyOn(globalThis, 'fetch').mockRejectedValue(new Error('ECONNRESET')) |
| 99 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'TRANSIENT' }) |
| 100 | + }) |
| 101 | + |
| 102 | + it('classifies non-JSON 200 body as MALFORMED', async () => { |
| 103 | + mockFetch(200, '<html>not json</html>') |
| 104 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'MALFORMED' }) |
| 105 | + }) |
| 106 | + |
| 107 | + it('classifies missing pull_count as MALFORMED', async () => { |
| 108 | + mockFetch(200, { name: 'x', star_count: 0 }) |
| 109 | + await expect(fetchDockerhub(BASE, 'a/b')).rejects.toMatchObject({ kind: 'MALFORMED' }) |
| 110 | + }) |
| 111 | +}) |
0 commit comments