fix: global PVTR_VERSION arg and structured error fields in runBinary

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Author: joanagmaia

scripts/services/docker/Dockerfile.security_best_practices_worker

@@ -1,3 +1,5 @@
+ARG PVTR_VERSION=v0.23.2
+
 FROM alpine:3.21 AS core
 RUN apk add --no-cache wget tar unzip
 
@@ -12,7 +14,7 @@ FROM golang:1.26.3-alpine3.23 AS plugin
 RUN apk add --no-cache make git
 WORKDIR /plugin
 ARG PVTR_COMMIT=c7bd9538d64f7eaab94a05c9b5fd05458a387b1c
-ARG PVTR_VERSION=v0.23.2
+ARG PVTR_VERSION
 # To run the latest version of the plugin, we need to use the latest commit of the pvtr-github-repo-scanner repository.
 # Currently using v0.23.2: https://github.com/ossf/pvtr-github-repo-scanner/commit/c7bd9538d64f7eaab94a05c9b5fd05458a387b1c
 RUN git clone https://github.com/ossf/pvtr-github-repo-scanner.git && cd pvtr-github-repo-scanner && git checkout ${PVTR_COMMIT}
@@ -36,7 +38,7 @@ FROM node:20-bookworm-slim as runner
 RUN mkdir -p /.privateer/bin
 WORKDIR /.privateer/bin
 COPY --from=core /app/pvtr ./privateer
-ARG PVTR_VERSION=v0.23.2
+ARG PVTR_VERSION
 COPY --from=plugin /plugin/github-repo /root/.privateer/bin/github-repo
 RUN echo "{\"plugins\":[{\"name\":\"github-repo\",\"version\":\"${PVTR_VERSION}\",\"binaryPath\":\"github-repo\"}]}" > /root/.privateer/bin/plugins.json
 COPY ./services/apps/security_best_practices_worker/example-config.yml /.privateer/example-config.yml

services/apps/security_best_practices_worker/src/activities/index.ts

@@ -226,11 +226,13 @@ async function runBinary(
         resolve({ stdout, stderr })
       } else {
         const truncated = (s: string) => (s.length > 500 ? s.slice(0, 500) + '…' : s)
-        reject(
+        const err = Object.assign(
           new Error(
-            `Binary exited with code ${code}\nStderr:\n${truncated(stderr)}Stdout:\n${truncated(stdout)}`,
+            `Binary exited with code ${code}\nStderr:\n${truncated(stderr)}\nStdout:\n${truncated(stdout)}`,
           ),
+          { stdout, stderr },
         )
+        reject(err)
       }
     })
   })