fix: stabilize LFID enrichment child workflows under auth0 mutex (#4293)

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

Author: skwowet

services/apps/members_enrichment_worker/src/workflows/lf-auth0/enrichMemberWithLFAuth0.ts

@@ -7,7 +7,6 @@ import * as activities from '../../activities'
 import { ILFIDEnrichmentGithubProfile } from '../../sources/lfid/types'
 
 const {
-  refreshToken,
   getEnrichmentLFAuth0,
   getIdentitiesExistInOtherMembers,
   updateMemberWithEnrichmentData,
@@ -22,8 +21,7 @@ const {
   },
 })
 
-export async function enrichMemberWithLFAuth0(member: IMember): Promise<void> {
-  const token = await refreshToken()
+export async function enrichMemberWithLFAuth0(token: string, member: IMember): Promise<void> {
   const enriched = await getEnrichmentLFAuth0(token, member)
 
   if (enriched) {

services/apps/members_enrichment_worker/src/workflows/lf-auth0/getMembersForLFIDEnrichment.ts

@@ -6,8 +6,6 @@ import {
   proxyActivities,
 } from '@temporalio/workflow'
 
-import { IMember } from '@crowd/types'
-
 import * as activities from '../../activities'
 import { IGetMembersForLFIDEnrichmentArgs } from '../../sources/lfid/types'
 import { enrichMemberWithLFAuth0 } from '../lf-auth0/enrichMemberWithLFAuth0'
@@ -16,6 +14,15 @@ const { getLFIDEnrichableMembers } = proxyActivities<typeof activities>({
   startToCloseTimeout: '10 seconds',
 })
 
+const { refreshToken } = proxyActivities<typeof activities>({
+  startToCloseTimeout: '2 minutes',
+  retry: {
+    initialInterval: '2 seconds',
+    backoffCoefficient: 2,
+    maximumAttempts: 3,
+  },
+})
+
 export async function getMembersForLFIDEnrichment(
   args: IGetMembersForLFIDEnrichmentArgs,
 ): Promise<void> {
@@ -27,23 +34,23 @@ export async function getMembersForLFIDEnrichment(
     return
   }
 
-  await Promise.all(
-    members.map((member: IMember) => {
-      return executeChild(enrichMemberWithLFAuth0, {
-        workflowId: 'member-enrichment-lfid/' + member.id,
-        cancellationType: ChildWorkflowCancellationType.ABANDON,
-        parentClosePolicy: ParentClosePolicy.PARENT_CLOSE_POLICY_ABANDON,
-        workflowExecutionTimeout: '1 minute',
-        retry: {
-          backoffCoefficient: 2,
-          maximumAttempts: 10,
-          initialInterval: 2 * 1000,
-          maximumInterval: 30 * 1000,
-        },
-        args: [member],
-      })
-    }),
-  )
+  const token = await refreshToken()
+
+  for (const member of members) {
+    await executeChild(enrichMemberWithLFAuth0, {
+      workflowId: 'member-enrichment-lfid/' + member.id,
+      cancellationType: ChildWorkflowCancellationType.ABANDON,
+      parentClosePolicy: ParentClosePolicy.PARENT_CLOSE_POLICY_ABANDON,
+      workflowExecutionTimeout: '10 minutes',
+      retry: {
+        backoffCoefficient: 2,
+        maximumAttempts: 10,
+        initialInterval: 2 * 1000,
+        maximumInterval: 30 * 1000,
+      },
+      args: [token, member],
+    })
+  }
 
   await continueAsNew<typeof getMembersForLFIDEnrichment>({
     afterId: members[members.length - 1].id,