Skip to content

Commit 1c4dfd5

Browse files
committed
fix: resolve pr review comments
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
1 parent 237b1eb commit 1c4dfd5

2 files changed

Lines changed: 2 additions & 14 deletions

File tree

frontend/src/modules/data-quality/components/member/data-quality-member-merge-suggestions.vue

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ import LfSpinner from '@/ui-kit/spinner/Spinner.vue';
6262
import LfButton from '@/ui-kit/button/Button.vue';
6363
import LfIcon from '@/ui-kit/icon/Icon.vue';
6464
import AppMemberMergeSuggestionsDialog from '@/modules/member/components/member-merge-suggestions-dialog.vue';
65-
import { storeToRefs } from 'pinia';
66-
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
6765
import LfMemberMergeSuggestionDropdown
6866
from '@/modules/member/components/suggestions/member-merge-suggestion-dropdown.vue';
6967
import LfScrollBodyControll from '@/ui-kit/scrollcontroll/ScrollBodyControll.vue';
@@ -81,11 +79,7 @@ const mergeSuggestions = ref<any[]>([]);
8179
const isModalOpen = ref<boolean>(false);
8280
const detailsOffset = ref<number>(0);
8381
84-
const { selectedProjectGroup } = storeToRefs(useLfSegmentsStore());
85-
86-
const segments = computed(() => (selectedProjectGroup.value?.id === props.projectGroup
87-
? [selectedProjectGroup.value?.id]
88-
: [props.projectGroup]));
82+
const segments = computed(() => [props.projectGroup]);
8983
9084
const loadMergeSuggestions = () => {
9185
loading.value = true;

frontend/src/modules/data-quality/components/organization/data-quality-organization-merge-suggestions.vue

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ import LfDataQualityOrganizationMergeSuggestionsItem
5858
from '@/modules/data-quality/components/organization/data-quality-organization-merge-suggestions-item.vue';
5959
import AppOrganizationMergeSuggestionsDialog
6060
from '@/modules/organization/components/organization-merge-suggestions-dialog.vue';
61-
import { storeToRefs } from 'pinia';
62-
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
6361
import LfScrollBodyControll from '@/ui-kit/scrollcontroll/ScrollBodyControll.vue';
6462
6563
const props = defineProps<{
@@ -75,11 +73,7 @@ const mergeSuggestions = ref<any[]>([]);
7573
const isModalOpen = ref<boolean>(false);
7674
const detailsOffset = ref<number>(0);
7775
78-
const { selectedProjectGroup } = storeToRefs(useLfSegmentsStore());
79-
80-
const segments = computed(() => (selectedProjectGroup.value?.id === props.projectGroup
81-
? [selectedProjectGroup.value?.id]
82-
: [props.projectGroup]));
76+
const segments = computed(() => [props.projectGroup]);
8377
8478
const loadMergeSuggestions = () => {
8579
loading.value = true;

0 commit comments

Comments
 (0)