Skip to content

Commit 1f8fcdb

Browse files
committed
fix: code comments
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
1 parent 33411ae commit 1f8fcdb

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

services/apps/merge_suggestions_worker/src/memberSimilarityCalculator.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,8 @@ class MemberSimilarityCalculator {
200200
similarMember: IMemberOpensearch,
201201
): boolean {
202202
if (member.identities && member.identities.length > 0) {
203+
// Only verified usernames are authoritative enough to veto merges; unverified social
204+
// slugs mostly come from enrichment and should not block stronger identity evidence.
203205
for (const identity of member.identities.filter(
204206
(i) => i.type === MemberIdentityType.USERNAME && i.verified,
205207
)) {
@@ -468,8 +470,8 @@ class MemberSimilarityCalculator {
468470
similarMember: IMemberOpensearch,
469471
startingScore?: number,
470472
): number {
471-
// displayName equality (startingScore omitted) is itself a high-confidence signal — don't
472-
// gate on metadata. Edit-distance callers pass a score and must have at least one signal.
473+
// Exact displayName widens the candidate funnel for sparse git-only profiles.
474+
// The LLM prompt still rejects display-name-only matches before merging.
473475
let isHighConfidence = startingScore === undefined
474476
let confidenceScore =
475477
startingScore != null && Number.isFinite(startingScore)

0 commit comments

Comments
 (0)