fix: return conflict for duplicate verified member identities (CM-1133) (#4062)

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

Author: skwowet

backend/src/api/public/openapi.yaml

@@ -319,6 +319,16 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/HttpError'
+        '409':
+          description: Identity is already verified on another member.
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/HttpError'
+              example:
+                error:
+                  code: CONFLICT
+                  message: Identity already verified on another member
 
   # ──────────────────────────────────────────────
   # Maintainer Roles

backend/src/api/public/v1/members/identities/verifyMemberIdentity.ts

@@ -6,7 +6,7 @@ import {
   memberUnmergeAction,
   memberVerifyIdentityAction,
 } from '@crowd/audit-logs'
-import { InternalError, NotFoundError } from '@crowd/common'
+import { ConflictError, InternalError, NotFoundError } from '@crowd/common'
 import {
   invalidateMemberQueryCache,
   prepareMemberUnmerge,
@@ -85,10 +85,21 @@ export async function verifyMemberIdentity(req: Request, res: Response): Promise
       captureOldState(identity)
 
       await qx.tx(async (tx) => {
-        updatedIdentity = await updateMemberIdentity(tx, memberId, identityId, {
-          verified,
-          verifiedBy,
-        })
+        try {
+          updatedIdentity = await updateMemberIdentity(tx, memberId, identityId, {
+            verified,
+            verifiedBy,
+          })
+        } catch (error) {
+          const constraint =
+            error.constraint ?? error.original?.constraint ?? error.parent?.constraint
+
+          if (verified && constraint === 'uix_memberIdentities_platform_value_type_verified') {
+            throw new ConflictError('Identity already verified on another member')
+          }
+
+          throw error
+        }
 
         if (!updatedIdentity) {
           throw new InternalError('Failed to update member identity')