Skip to content

Commit 29bcdda

Browse files
committed
chore: small refactor to cover what happens after the member merge
Signed-off-by: Uroš Marolt <uros@marolt.me>
1 parent 56f2c5e commit 29bcdda

3 files changed

Lines changed: 120 additions & 181 deletions

File tree

services/apps/cron_service/src/jobs/integrationResultsReporting.job.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ const job: IJobDefinition = {
6363
).count
6464

6565
// Break down errors by errorMessage + location, enriched with platform info.
66-
// When a mergeError is present in metadata, prefer its errorMessage for grouping
67-
// so merge crashes surface as distinct groups rather than collapsing into the
68-
// generic outer errorMessage.
66+
// Prefer metadata.errorMessage when set — the data sink worker writes specific
67+
// values there (e.g. "noMerge blocked", "merge failed") so those surface as
68+
// distinct groups rather than collapsing into the generic outer errorMessage.
6969
const errorGroups = await dbConnection.any<IErrorGroup>(
7070
`
7171
SELECT

services/apps/data_sink_worker/src/service/activity.service.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,8 +1346,11 @@ export default class ActivityService extends LoggerBase {
13461346
orgPromiseCache,
13471347
payload.activity.timestamp,
13481348
)
1349-
.then(() => {
1350-
payload.memberId = payload.dbMember.id
1349+
.then((redirectId?: string) => {
1350+
payload.memberId = redirectId ?? payload.dbMember.id
1351+
if (redirectId) {
1352+
memberMap.set(key, redirectId)
1353+
}
13511354
})
13521355
.catch(async (err) => {
13531356
const result = await this.handleMemberIdentityError(
@@ -1405,8 +1408,11 @@ export default class ActivityService extends LoggerBase {
14051408
orgPromiseCache,
14061409
payload.activity.timestamp,
14071410
)
1408-
.then(() => {
1409-
payload.objectMemberId = payload.dbObjectMember.id
1411+
.then((redirectId?: string) => {
1412+
payload.objectMemberId = redirectId ?? payload.dbObjectMember.id
1413+
if (redirectId) {
1414+
memberMap.set(key, redirectId)
1415+
}
14101416
})
14111417
.catch(async (err) => {
14121418
const result = await this.handleMemberIdentityError(

0 commit comments

Comments
 (0)