Skip to content

Commit 34e3abe

Browse files
committed
fix: address PR review comments on Claude config
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
1 parent 1f517dc commit 34e3abe

4 files changed

Lines changed: 34 additions & 23 deletions

File tree

.claude/agents/code-standards-enforcer.md

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,25 @@ After auditing all files, provide:
114114

115115
## Output Format
116116

117+
Return findings as a JSON array first, then a brief markdown summary.
118+
119+
**Part 1 — JSON findings** (used by `/review-pr` Phase 5 for filtering and compilation):
120+
121+
```json
122+
[
123+
{
124+
"file": "backend/src/api/members.ts",
125+
"line": 12,
126+
"severity": "CRITICAL|SHOULD_FIX|NIT",
127+
"rule": "<source>:<section>",
128+
"message": "...",
129+
"suggestion": "..."
130+
}
131+
]
132+
```
133+
134+
**Part 2 — Markdown summary** (human-readable):
135+
117136
```text
118137
## Code Standards Audit Report
119138
@@ -126,20 +145,6 @@ After auditing all files, provide:
126145
### Protected Files
127146
- [List any protected files that were modified, or "None modified"]
128147
129-
### Violations Found
130-
131-
#### CRITICAL
132-
[Violations that break core patterns or introduce security/data issues]
133-
134-
#### SHOULD FIX
135-
[Deviations from documented conventions]
136-
137-
#### NIT
138-
[Minor style issues, protected-file awareness]
139-
140-
### Correctly Followed
141-
[Notable rules that were correctly followed]
142-
143148
### Verdict: PASS / FAIL
144-
[Summary and priority fixes]
149+
[Total violations by severity. Top 3 priority fixes.]
145150
```

.claude/hooks/guard-protected-files.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ fi
8282
case "$FILE_PATH" in
8383
tsconfig*.json|*/tsconfig*.json)
8484
warn "TypeScript configuration — changes affect compilation across the monorepo." ;;
85-
.eslintrc*|*/eslintrc*|eslint.config*|*/eslint.config*)
85+
.eslintrc*|*/.eslintrc*|eslint.config*|*/eslint.config*)
8686
warn "ESLint configuration — changes affect code quality rules for the project." ;;
8787
.prettierrc*|*/.prettierrc*)
8888
warn "Prettier configuration — changes affect code formatting standards." ;;

.claude/settings.json

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"hooks": {
77
"PreToolUse": [
88
{
9-
"matcher": "Edit|Write",
9+
"matcher": "Edit|Write|MultiEdit",
1010
"hooks": [
1111
{
1212
"type": "command",
@@ -34,11 +34,17 @@
3434
"Bash(pnpm lint*)",
3535
"Bash(pnpm format-check*)",
3636
"Bash(pnpm tsc-check*)",
37-
"Bash(npm run lint*)"
37+
"Bash(pnpm format*)",
38+
"Bash(pnpm test*)",
39+
"Bash(npm run lint*)",
40+
"Bash(git commit*)",
41+
"Bash(git rebase*)",
42+
"Bash(git cherry-pick*)",
43+
"Bash(git push*)"
3844
],
3945
"deny": [
4046
"Bash(git reset --hard*)",
41-
"Bash(git push --force *)",
47+
"Bash(git push --force*)",
4248
"Bash(rm -rf*)"
4349
]
4450
}

.claude/skills/preflight/SKILL.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ git diff --name-only origin/main...HEAD
4242

4343
Group changed files into workspaces:
4444

45-
| Workspace | Path prefix | Lint command | Format check | Type check | Test |
45+
| Workspace | Path prefix | Lint | Format check | Type check | Test |
4646
|---|---|---|---|---|---|
47-
| Backend | `backend/` | `cd backend && pnpm lint` | `pnpm format-check` | `pnpm tsc-check` | `pnpm test` (needs Docker) |
47+
| Backend | `backend/` | `cd backend && pnpm lint` | `cd backend && pnpm format-check` | `cd backend && pnpm tsc-check` | `cd backend && pnpm test` (needs Docker) |
4848
| Frontend | `frontend/` | `cd frontend && npm run lint` ||||
49-
| Each service | `services/apps/<name>/` | `pnpm lint` | `pnpm format-check` | `pnpm tsc-check` | `pnpm test` if vitest present |
50-
| Each lib | `services/libs/<name>/` | `pnpm lint` | `pnpm format-check` | `pnpm tsc-check` | `pnpm test` if vitest present |
49+
| Each service | `services/apps/<name>/` | `cd services/apps/<name> && pnpm lint` | `cd services/apps/<name> && pnpm format-check` | `cd services/apps/<name> && pnpm tsc-check` | `cd services/apps/<name> && pnpm test` if vitest present |
50+
| Each lib | `services/libs/<name>/` | `cd services/libs/<name> && pnpm lint` | `cd services/libs/<name> && pnpm format-check` | `cd services/libs/<name> && pnpm tsc-check` | `cd services/libs/<name> && pnpm test` if vitest present |
5151

5252
Run checks only for the workspaces that have changed files.
5353

0 commit comments

Comments
 (0)