Fixed edge case in engagement score normalisation (#7)

Author: CallmeMehdi

backend/src/serverless/microservices/python/crowd-members-score/crowd/members_score/members_score.py

@@ -24,11 +24,6 @@ def __init__(self, tenant_id, repository=False, test=False, send=True):
             self.repository = repository
 
         self.fetch_scores()
-        # print([
-        #     member.id for member in self.repository.find_all(Tenant, query={})
-        # ])
-
-        print(self.tenants.fetchall())
         self.team_members = [
             member.id for member in self.repository.find_all(CommunityMember, query={"crowdInfo.team": True})
         ]
@@ -76,11 +71,7 @@ def fetch_scores(self):
                 group by "communityMemberId", date("timestamp")) T on T."cm_id"=FullDates."communityMemberId" and T."timestamp" = FullDates.MyJoinDate\
                 group by FullDates."communityMemberId", FullDates.MyJoinDate order by FullDates.MyJoinDate asc\
                 ) Daily group by "communityMemberId", extract(month from MyJoinDate), extract(year from MyJoinDate)'
-            )
-
-            self.tenants = con.execute(
-                'select count(*), "tenantId" from "communityMembers" cm group by "tenantId" order by count(*) ASC'
-            )
+            ).fetchall()
 
     def _calculate_months(self, date):
         """
@@ -140,9 +131,7 @@ def _member_scores_(self, members):
         to the score of the member.
         """
 
-        id = self.repository.tenant_id
-
-        mean_scores = self.mean_scores.fetchall()
+        mean_scores = self.mean_scores
 
         scores = {}
         for i, row in enumerate(mean_scores):
@@ -218,6 +207,10 @@ def main(self):
         self.scores = self._member_scores_(members)
         logger.info("Done")
 
+        # Take care of case where tenant doesn't have activities
+        if len(self.scores) == 0:
+            return {}
+
         logger.info("Normalising scores...")
         scores_to_update = self.normalise(self.scores)
         logger.info("Done")