Skip to content

Commit 42f823a

Browse files
authored
fix: active contributors maintainers count (IN-1175) (#4226)
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
1 parent 307230a commit 42f823a

2 files changed

Lines changed: 15 additions & 4 deletions

File tree

services/libs/tinybird/pipes/active_contributors.pipe

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ SQL >
5252
NODE maintainers_count
5353
SQL >
5454
%
55-
SELECT uniq(memberId) AS maintainerCount
55+
SELECT uniqIf(memberId, memberId != '') AS maintainerCount
5656
FROM maintainers_roles_copy_ds
5757
WHERE
58-
insightsProjectId = (SELECT insightsProjectId FROM segments_filtered)
58+
insightsProjectId = (SELECT insightsProjectId FROM segments_filtered) AND role = 'maintainer'
5959
{% if defined(repos) %}
6060
AND repoUrl
6161
IN {{ Array(repos, 'String', description="Filter maintainer repo list", required=False) }}
@@ -73,7 +73,8 @@ SQL >
7373
OR endDate
7474
>= {% if defined(startDate) %}
7575
{{ DateTime(startDate, description="Filter maintainer start date", required=False) }}
76-
{% else %} toDateTime64('1970-01-01 00:00:00', 3)
76+
{% elif defined(endDate) %} toDateTime64('1970-01-01 00:00:00', 3)
77+
{% else %} now()
7778
{% end %}
7879
)
7980

services/libs/tinybird/pipes/maintainers_roles_copy.pipe

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,17 @@ SQL >
77

88
NODE maintainers_roles_copy_member_identities_deduplicated
99
SQL >
10-
SELECT id, memberId FROM memberIdentities FINAL WHERE isNull (deletedAt)
10+
SELECT id, memberId
11+
FROM
12+
(
13+
SELECT
14+
id,
15+
argMax((mi.memberId, mi.deletedAt), mi.updatedAt) .1 AS memberId,
16+
argMax((mi.memberId, mi.deletedAt), mi.updatedAt) .2 AS deletedAt
17+
FROM memberIdentities as mi
18+
GROUP BY id
19+
) AS deduped
20+
WHERE isNull (deduped.deletedAt)
1121

1222
NODE maintainers_roles_copy_maintainers_deduplicated
1323
SQL >

0 commit comments

Comments
 (0)