Skip to content

Commit 484fd58

Browse files
authored
Cubejs preaggregations dimension updates (#386)
1 parent c9ba76a commit 484fd58

4 files changed

Lines changed: 22 additions & 8 deletions

File tree

backend/src/cubejs/schema/Activities.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ cube(`Activities`, {
1010
Members.score,
1111
Members.location,
1212
Members.tenantId,
13+
Members.isTeamMember,
14+
Members.isBot,
1315
Activities.tenantId,
1416
],
1517
timeDimension: Activities.date,

backend/src/cubejs/schema/Members.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,14 @@ cube(`Members`, {
1515
preAggregations: {
1616
ActiveMembers: {
1717
measures: [Members.count],
18-
dimensions: [Members.score, Members.location, Members.tenantId, Tags.name],
18+
dimensions: [
19+
Members.score,
20+
Members.location,
21+
Members.tenantId,
22+
Tags.name,
23+
Members.isTeamMember,
24+
Members.isBot,
25+
],
1926
timeDimension: Members.joinedAt,
2027
granularity: `day`,
2128
refreshKey: {
@@ -25,7 +32,13 @@ cube(`Members`, {
2532

2633
MembersActivities: {
2734
measures: [Members.count],
28-
dimensions: [Members.tenantId, Activities.platform, Activities.type],
35+
dimensions: [
36+
Members.tenantId,
37+
Activities.platform,
38+
Activities.type,
39+
Members.isTeamMember,
40+
Members.isBot,
41+
],
2942
timeDimension: Members.joinedAt,
3043
granularity: `day`,
3144
refreshKey: {
@@ -35,7 +48,7 @@ cube(`Members`, {
3548

3649
MembersTags: {
3750
measures: [Members.count],
38-
dimensions: [Members.tenantId, Tags.name],
51+
dimensions: [Members.tenantId, Tags.name, Members.isTeamMember, Members.isBot],
3952
timeDimension: Members.joinedAt,
4053
granularity: `day`,
4154
refreshKey: {

backend/src/cubejs/schema/Organizations.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ cube(`Organizations`, {
44
preAggregations: {
55
activeOrganizations: {
66
measures: [Organizations.count],
7-
dimensions: [Organizations.tenantId],
7+
dimensions: [Organizations.tenantId, Members.isTeamMember, Members.isBot],
88
timeDimension: Activities.date,
99
granularity: `day`,
1010
},
1111
newOrganizations: {
1212
measures: [Organizations.count],
13-
dimensions: [Organizations.tenantId],
13+
dimensions: [Organizations.tenantId, Members.isTeamMember, Members.isBot],
1414
timeDimension: Organizations.joinedAt,
1515
granularity: `day`,
1616
},

backend/src/services/__tests__/tenantService.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,15 @@ describe('TenantService tests', () => {
146146

147147
tenantCreatedPlain.createdAt = tenantCreatedPlain.createdAt.toISOString().split('T')[0]
148148
tenantCreatedPlain.updatedAt = tenantCreatedPlain.updatedAt.toISOString().split('T')[0]
149+
tenantCreatedPlain.trialEndsAt = tenantCreatedPlain.trialEndsAt.toISOString().split('T')[0]
149150

150151
const tenantExpected = {
151152
id: tenantCreatedPlain.id,
152153
name: 'testName',
153154
url: 'testUrl',
154155
plan: Plans.values.growth,
155156
isTrialPlan: true,
156-
trialEndsAt: moment().add(14, 'days').isAfter('2023-01-15')
157-
? moment().add(14, 'days').toISOString()
158-
: new Date('2023-01-15T00:00:00.000Z'),
157+
trialEndsAt: moment().add(14, 'days').toISOString().split('T')[0],
159158
planStatus: 'active',
160159
planStripeCustomerId: null,
161160
planUserId: null,

0 commit comments

Comments
 (0)