Skip to content

Commit 4a7e5ca

Browse files
committed
fix: comments
Signed-off-by: Uroš Marolt <uros@marolt.me>
1 parent c2ba05e commit 4a7e5ca

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

services/apps/packages_worker/src/deps-dev/workflows/ingestDependencies.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,13 +259,17 @@ export async function ingestDependencies(opts: {
259259
jobKind: 'package_dependencies',
260260
sql,
261261
runId: opts.runId,
262-
syncMode: opts.syncMode,
262+
// Report the PHYSICAL scan mode, not the requested one. A fill run (fillConstraints) forces a
263+
// full *Latest scan even when opts.syncMode is 'incremental'; passing the raw mode would record
264+
// the job as incremental and make bqExportToGcs pick the INCREMENTAL byte-ceiling env override
265+
// for a query that's actually full. fullScan already gates the SQL + maxBytesGb below.
266+
syncMode: fullScan ? 'full' : opts.syncMode,
263267
snapshotAt: opts.today,
264268
// Full/fill scan the *Latest views (everything) → 25000. Incremental is a snapshot edge-diff
265269
// (today vs watermark partitions of DependencyGraphEdges + GoRequirements + NuGetRequirements);
266270
// measured ~4.1TB for Option A. 10000 leaves ~2.4x headroom and still trips a runaway full-table
267271
// scan. Overridable via BQ_DATASET_INGEST_PACKAGE_DEPENDENCIES[_INCREMENTAL]_MAX_BQ_GB (see README).
268-
maxBytesGb: opts.syncMode === 'full' || isFill ? 25000 : 10000,
272+
maxBytesGb: fullScan ? 25000 : 10000,
269273
reuseExports: opts.reuseExports,
270274
exportName: opts.exportName,
271275
ecosystems,

0 commit comments

Comments
 (0)