Skip to content

Commit 58217ee

Browse files
committed
fix: reverd useless changes
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
1 parent dbc9643 commit 58217ee

10 files changed

Lines changed: 63 additions & 16 deletions

File tree

backend/src/database/repositories/segmentRepository.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,7 @@ class SegmentRepository extends RepositoryBase<
331331
join segment_level sl on (sl.level = 'child' and s.id = sl.id)
332332
or (sl.level = 'parent' and s."parentSlug" = sl.slug and s."grandparentSlug" is not null)
333333
or (sl.level = 'grandparent' and s."grandparentSlug" = sl.slug)
334-
where s.status = 'active'
335-
and s."tenantId" = :tenantId;
334+
where status = 'active';
336335
`,
337336
{
338337
replacements: {

frontend/src/modules/activity/config/filters/activityType/ActivityTypeFilter.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
} from '@/shared/modules/filters/types/filterTypes/MultiSelectFilterConfig';
1515
import { CustomFilterConfig } from '@/shared/modules/filters/types/filterTypes/CustomFilterConfig';
1616
import { useActivityTypeStore } from '@/modules/activity/store/type';
17+
import { getSegmentsFromProjectGroup } from '@/utils/segments';
1718
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
1819
import { lfIdentities } from '@/config/identities';
1920
import useIntegrationsHelpers from '@/config/integrations/integrations.helpers';
@@ -76,6 +77,6 @@ watch([types, activeIntegrations], ([typesValue, activeIntegrationsValue]) => {
7677
});
7778
7879
onMounted(async () => {
79-
await store.dispatch('integration/doFetch', selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : []);
80+
await store.dispatch('integration/doFetch', getSegmentsFromProjectGroup(selectedProjectGroup.value));
8081
});
8182
</script>

frontend/src/modules/data-quality/components/member/data-quality-member-merge-suggestions.vue

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ import LfSpinner from '@/ui-kit/spinner/Spinner.vue';
6262
import LfButton from '@/ui-kit/button/Button.vue';
6363
import LfIcon from '@/ui-kit/icon/Icon.vue';
6464
import AppMemberMergeSuggestionsDialog from '@/modules/member/components/member-merge-suggestions-dialog.vue';
65+
import { storeToRefs } from 'pinia';
66+
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
6567
import LfMemberMergeSuggestionDropdown
6668
from '@/modules/member/components/suggestions/member-merge-suggestion-dropdown.vue';
6769
import LfScrollBodyControll from '@/ui-kit/scrollcontroll/ScrollBodyControll.vue';
@@ -79,7 +81,23 @@ const mergeSuggestions = ref<any[]>([]);
7981
const isModalOpen = ref<boolean>(false);
8082
const detailsOffset = ref<number>(0);
8183
82-
const segments = computed(() => [props.projectGroup]);
84+
const { selectedProjectGroup } = storeToRefs(useLfSegmentsStore());
85+
86+
const segments = computed(() => (selectedProjectGroup.value?.id === props.projectGroup
87+
? [
88+
selectedProjectGroup.value?.id,
89+
...selectedProjectGroup.value.projects.map((p) => [
90+
...p.subprojects.map((sp) => sp.id),
91+
]).flat(),
92+
]
93+
: [
94+
props.projectGroup,
95+
...selectedProjectGroup.value.projects
96+
.filter((p) => p.id === props.projectGroup)
97+
.map((p) => [
98+
...p.subprojects.map((sp) => sp.id),
99+
]).flat(),
100+
]));
83101
84102
const loadMergeSuggestions = () => {
85103
loading.value = true;

frontend/src/modules/data-quality/components/organization/data-quality-organization-merge-suggestions.vue

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ import LfDataQualityOrganizationMergeSuggestionsItem
5858
from '@/modules/data-quality/components/organization/data-quality-organization-merge-suggestions-item.vue';
5959
import AppOrganizationMergeSuggestionsDialog
6060
from '@/modules/organization/components/organization-merge-suggestions-dialog.vue';
61+
import { storeToRefs } from 'pinia';
62+
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
6163
import LfScrollBodyControll from '@/ui-kit/scrollcontroll/ScrollBodyControll.vue';
6264
6365
const props = defineProps<{
@@ -73,7 +75,23 @@ const mergeSuggestions = ref<any[]>([]);
7375
const isModalOpen = ref<boolean>(false);
7476
const detailsOffset = ref<number>(0);
7577
76-
const segments = computed(() => [props.projectGroup]);
78+
const { selectedProjectGroup } = storeToRefs(useLfSegmentsStore());
79+
80+
const segments = computed(() => (selectedProjectGroup.value?.id === props.projectGroup
81+
? [
82+
selectedProjectGroup.value?.id,
83+
...selectedProjectGroup.value.projects.map((p) => [
84+
...p.subprojects.map((sp) => sp.id),
85+
]).flat(),
86+
]
87+
: [
88+
props.projectGroup,
89+
...selectedProjectGroup.value.projects
90+
.filter((p) => p.id === props.projectGroup)
91+
.map((p) => [
92+
...p.subprojects.map((sp) => sp.id),
93+
]).flat(),
94+
]));
7795
7896
const loadMergeSuggestions = () => {
7997
loading.value = true;

frontend/src/modules/lf/layout/components/lf-banners.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ import {
150150
watch, ref, computed, onUnmounted,
151151
} from 'vue';
152152
import { IntegrationService } from '@/modules/integration/integration-service';
153+
import { getSegmentsFromProjectGroup } from '@/utils/segments';
153154
import { isCurrentDateAfterGivenWorkingDays } from '@/utils/date';
154155
import { useRoute } from 'vue-router';
155156
import usePermissions from '@/shared/modules/permissions/helpers/usePermissions';
@@ -226,7 +227,7 @@ const showBanner = computed(() => (integrationsWithErrors.value.length
226227
227228
const fetchIntegrations = (projectGroup) => {
228229
if (projectGroup) {
229-
IntegrationService.list(null, null, null, null, [projectGroup.id])
230+
IntegrationService.list(null, null, null, null, getSegmentsFromProjectGroup(projectGroup))
230231
.then((response) => {
231232
integrations.value = response.rows;
232233
})

frontend/src/modules/member/components/list/member-list-table.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ import LfTable from '@/ui-kit/table/Table.vue';
424424
import LfTableCell from '@/ui-kit/table/TableCell.vue';
425425
import LfTableHead from '@/ui-kit/table/TableHead.vue';
426426
import { formatNumber } from '@/utils/number';
427+
import { getSegmentsFromProjectGroup } from '@/utils/segments';
427428
import { ClickOutside as vClickOutside } from 'element-plus';
428429
import { storeToRefs } from 'pinia';
429430
import {
@@ -678,7 +679,7 @@ const doExport = () => MemberService.export({
678679
onMounted(async () => {
679680
await store.dispatch(
680681
'integration/doFetch',
681-
selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : [],
682+
getSegmentsFromProjectGroup(selectedProjectGroup.value),
682683
);
683684
});
684685

frontend/src/modules/member/components/member-selection-dropdown.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const fetchFn = async ({ query, limit }) => {
8686
const options = await MemberService.listMembersAutocomplete({
8787
query,
8888
limit,
89-
segments: selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : [],
89+
segments: [selectedProjectGroup.value.id],
9090
});
9191
9292
// Remove primary member from members that can be merged with

frontend/src/modules/member/config/filters/activityType/ActivityTypeFilter.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
} from '@/shared/modules/filters/types/filterTypes/MultiSelectFilterConfig';
1515
import { CustomFilterConfig } from '@/shared/modules/filters/types/filterTypes/CustomFilterConfig';
1616
import { useActivityTypeStore } from '@/modules/activity/store/type';
17+
import { getSegmentsFromProjectGroup } from '@/utils/segments';
1718
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
1819
import useIntegrationsHelpers from '@/config/integrations/integrations.helpers';
1920
import { lfIntegrations } from '@/config/integrations';
@@ -76,6 +77,6 @@ watch([types, activeIntegrations], ([typesValue, activeIntegrationsValue]) => {
7677
});
7778
7879
onMounted(async () => {
79-
await store.dispatch('integration/doFetch', selectedProjectGroup.value?.id ? [selectedProjectGroup.value.id] : []);
80+
await store.dispatch('integration/doFetch', getSegmentsFromProjectGroup(selectedProjectGroup.value));
8081
});
8182
</script>

frontend/src/modules/organization/organization-service.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import authAxios from '@/shared/axios/auth-axios';
22
import { AuthService } from '@/modules/auth/services/auth.service'; import { storeToRefs } from 'pinia';
33
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
4+
import { getSegmentsFromProjectGroup } from '@/utils/segments';
45

56
const getSelectedProjectGroup = () => {
67
const lsSegmentsStore = useLfSegmentsStore();
@@ -215,9 +216,10 @@ export class OrganizationService {
215216
}
216217

217218
static async fetchMergeSuggestions(limit, offset, query) {
218-
const segments = getSelectedProjectGroup()?.id
219-
? [getSelectedProjectGroup().id]
220-
: [];
219+
const segments = [
220+
...getSegmentsFromProjectGroup(getSelectedProjectGroup()),
221+
getSelectedProjectGroup().id,
222+
];
221223

222224
const data = {
223225
limit,

frontend/src/modules/organization/services/organization.api.service.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import authAxios from '@/shared/axios/auth-axios';
22
import { Organization } from '@/modules/organization/types/Organization';
3+
import { getSegmentsFromProjectGroup } from '@/utils/segments';
34
import { useLfSegmentsStore } from '@/modules/lf/segments/store';
45
import { storeToRefs } from 'pinia';
56

@@ -29,12 +30,18 @@ export class OrganizationApiService {
2930
}
3031

3132
static async fetchMergeSuggestions(limit: number = 20, offset: number = 0, query: any = {}) {
32-
const segments = getSelectedProjectGroupId();
33+
const lsSegmentsStore = useLfSegmentsStore();
34+
const { selectedProjectGroup } = storeToRefs(lsSegmentsStore);
35+
36+
const segments = [
37+
...getSegmentsFromProjectGroup(selectedProjectGroup.value),
38+
selectedProjectGroup.value?.id,
39+
];
3340

3441
const data = {
3542
limit,
3643
offset,
37-
...(segments ? { segments } : {}),
44+
segments,
3845
...query,
3946
};
4047

@@ -46,12 +53,11 @@ export class OrganizationApiService {
4653
}
4754

4855
static create(data: Partial<Organization>) {
49-
const segments = getSelectedProjectGroupId();
5056
return authAxios.post(
5157
'/organization',
5258
{
5359
...data,
54-
...(segments ? { segments } : {}),
60+
segments: getSelectedProjectGroupId(),
5561
},
5662
)
5763
.then(({ data }) => Promise.resolve(data));

0 commit comments

Comments
 (0)