Skip to content

Commit 5ef4006

Browse files
committed
fix: resolve pr review comments
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
1 parent 8b17d5d commit 5ef4006

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

docs/adr/0012-api-e2e-test-architecture.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
## Context
88

9-
We want to catch API regressions on main sooner (auth, routing, validation, and the synchronous HTTP response contract) instead of waiting for a consumer to hit a problem. Manually running the test script is easy to forget, pollutes staging data, depends on existing fixtures, and is not something we can rely on as a team.
9+
We want to catch API regressions on main sooner (routing, validation, and the synchronous HTTP response contract with a valid token) instead of waiting for a consumer to hit a problem. Manually running the test script is easy to forget, pollutes staging data, depends on existing fixtures, and is not something we can rely on as a team.
1010

1111
A more complete API e2e harness in the server test setup (PR CI, isolated fixtures, typed assertions) is planned for future work. Until then, we need a simple automated check that runs against an isolated environment and gives us confidence that the deployed API is still working as expected.
1212

@@ -69,7 +69,7 @@ flowchart LR
6969

7070
### What we assert (and what we do not)
7171

72-
- **Assert**: auth/scopes, routing, validation, sync response shape and critical flows.
72+
- **Assert**: routing, validation, sync response shape and critical flows using a valid fully scoped token.
7373
- **Do not assert**: Temporal / OpenSearch eventual outcomes. Some writes await Temporal accepting a signal before the HTTP response returns; async worker work stays out of scope for this suite.
7474

7575
### Not a PR gate

0 commit comments

Comments
 (0)