chore: improve message body

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Author: joanagmaia

backend/src/api/public/middlewares/errorHandler.ts

@@ -24,8 +24,7 @@ export const errorHandler: ErrorRequestHandler = (
   _next: NextFunction,
 ) => {
   if (error instanceof ConflictError) {
-    const memberIds = (error as ConflictError & { memberIds?: string[] }).memberIds
-    req.log.warn({ memberIds }, 'Public API conflict')
+    req.log.warn({ context: error.context }, 'Public API conflict')
     sendSlackNotification(
       SlackChannel.CDP_LFX_SELF_SERVE_ALERTS,
       SlackPersona.WARNING_PROPAGATOR,
@@ -39,7 +38,9 @@ export const errorHandler: ErrorRequestHandler = (
           title: 'Conflict',
           text: `*Message:* ${error.message}`,
         },
-        ...(memberIds ? [{ title: 'Member IDs', text: memberIds.join(', ') }] : []),
+        ...(error.context
+          ? [{ title: 'Context', text: `\`\`\`${JSON.stringify(error.context, null, 2)}\`\`\`` }]
+          : []),
       ],
     )
     res.status(error.status).json(error.toJSON())

backend/src/api/public/v1/members/resolveMember.ts

@@ -4,7 +4,6 @@ import { z } from 'zod'
 import { ConflictError, NotFoundError } from '@crowd/common'
 import { findMemberIdsByIdentities, optionsQx } from '@crowd/data-access-layer'
 import { IMemberIdentity, MemberIdentityType, PlatformType } from '@crowd/types'
-
 import { ok } from '@/utils/api'
 import { validateOrThrow } from '@/utils/validation'
 
@@ -32,13 +31,7 @@ export async function resolveMemberByIdentities(req: Request, res: Response): Pr
   if (memberIds.length === 0) {
     throw new NotFoundError('Member not found')
   } else if (memberIds.length > 1) {
-    const error = new ConflictError('Conflicting identities')
-    Object.defineProperty(error, 'memberIds', {
-      value: memberIds,
-      enumerable: false,
-      configurable: true,
-    })
-    throw error
+    throw new ConflictError('Conflicting identities', { memberIds })
   }
 
   const memberId = memberIds[0]

services/libs/common/src/errors/http.ts

@@ -70,9 +70,11 @@ export class NotFoundError extends HttpError {
 export class ConflictError extends HttpError {
   readonly code = 'CONFLICT'
   readonly status = 409
+  readonly context?: Record<string, unknown>
 
-  constructor(message = 'Conflict') {
+  constructor(message = 'Conflict', context?: Record<string, unknown>) {
     super(message)
+    this.context = context
   }
 }