fix: copilot reviews

Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>

Author: ulemons

services/apps/members_enrichment_worker/src/activities/enrichment.ts

@@ -290,15 +290,15 @@ export async function updateMemberUsingSquashedPayload(
 ): Promise<boolean> {
   const affectedOrgIds: string[] = []
 
-  const updated = await svc.postgres.writer.transactionally(async (tx) => {
-    let updated = false
+  const wasUpdated = await svc.postgres.writer.transactionally(async (tx) => {
+    let didUpdate = false
     const qx = dbStoreQx(tx)
 
     // process identities
     if (squashedPayload.identities.length > 0) {
       svc.log.debug({ memberId }, 'Adding to member identities!')
       for (const i of squashedPayload.identities) {
-        updated = true
+        didUpdate = true
         await createMemberIdentity(
           qx,
           {
@@ -330,7 +330,7 @@ export async function updateMemberUsingSquashedPayload(
           const typed = normalized as IMemberEnrichmentDataNormalized
 
           if (typed.contributions) {
-            updated = true
+            didUpdate = true
             await updateMemberContributions(qx, memberId, typed.contributions)
           }
         }
@@ -349,7 +349,7 @@ export async function updateMemberUsingSquashedPayload(
         const priorities = await getPriorityArray()
         attributes = await setAttributesDefaultValues(attributes, priorities)
       }
-      updated = true
+      didUpdate = true
       await updateMemberAttributes(qx, memberId, attributes)
     }
 
@@ -369,7 +369,7 @@ export async function updateMemberUsingSquashedPayload(
           total,
         }
 
-        updated = true
+        didUpdate = true
         await updateMemberReach(qx, memberId, reach)
       }
     }
@@ -462,7 +462,7 @@ export async function updateMemberUsingSquashedPayload(
 
       if (results.toDelete.length > 0) {
         for (const org of results.toDelete) {
-          updated = true
+          didUpdate = true
           affectedOrgIds.push(org.orgId)
           await deleteMemberOrgById(tx.transaction(), org.id)
         }
@@ -473,7 +473,7 @@ export async function updateMemberUsingSquashedPayload(
           if (!org.organizationId) {
             throw new Error('Organization ID is missing!')
           }
-          updated = true
+          didUpdate = true
           affectedOrgIds.push(org.organizationId)
 
           const newMemberOrgId = await insertWorkExperience(
@@ -497,7 +497,7 @@ export async function updateMemberUsingSquashedPayload(
 
       if (results.toUpdate.size > 0) {
         for (const [memberOrg, toUpdate] of results.toUpdate) {
-          updated = true
+          didUpdate = true
           affectedOrgIds.push(memberOrg.orgId)
           const updatedMemberOrgId = await updateMemberOrg(
             tx.transaction(),
@@ -533,7 +533,7 @@ export async function updateMemberUsingSquashedPayload(
       }
     }
 
-    if (updated) {
+    if (didUpdate) {
       await setMemberEnrichmentUpdatedAt(tx.transaction(), memberId)
       await syncMember(memberId)
     } else {
@@ -542,7 +542,7 @@ export async function updateMemberUsingSquashedPayload(
 
     svc.log.debug({ memberId }, 'Member sources processed successfully!')
 
-    return updated
+    return didUpdate
   })
 
   if (affectedOrgIds.length > 0) {
@@ -551,9 +551,7 @@ export async function updateMemberUsingSquashedPayload(
       svc.temporal,
       svc.log,
     )
-    await commonMemberService.startAffiliationRecalculation(memberId, [
-      ...new Set(affectedOrgIds),
-    ])
+    await commonMemberService.startAffiliationRecalculation(memberId, [...new Set(affectedOrgIds)], true)
   }
 
   return updated