fix: skip deleted members in stint inference cron job (#4260)

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

Author: skwowet

services/apps/cron_service/src/jobs/inferMemberOrganizationStintChanges.job.ts

@@ -7,18 +7,20 @@ import {
   signalMemberUpdate,
 } from '@crowd/common_services'
 import {
+  MemberField,
   QueryExecutor,
   changeMemberOrganizationAffiliationOverrides,
   createMemberOrganization,
   deleteUndatedMemberOrganizations,
   fetchManyOrganizationAffiliationPolicies,
   fetchMemberOrganizationsBySource,
+  findMemberById,
   updateMemberOrganization,
 } from '@crowd/data-access-layer'
 import { WRITE_DB_CONFIG, getDbConnection } from '@crowd/data-access-layer/src/database'
 import { deleteMemberSegmentAffiliations } from '@crowd/data-access-layer/src/member_segment_affiliations'
 import { pgpQx } from '@crowd/data-access-layer/src/queryExecutor'
-import { REDIS_CONFIG, RedisCache, getRedisClient } from '@crowd/redis'
+import { REDIS_CONFIG, RedisCache, RedisClient, getRedisClient } from '@crowd/redis'
 import { TEMPORAL_CONFIG, getTemporalClient } from '@crowd/temporal'
 import { MemberOrgDate, MemberOrgStintChange, OrganizationSource } from '@crowd/types'
 
@@ -51,7 +53,18 @@ const job: IJobDefinition = {
         const rawMembers = await redis.sMembers(datesKey)
 
         if (!rawMembers?.length) {
-          await redis.sRem(MEMBER_ORG_STINT_CHANGES_QUEUE, memberId)
+          await purgeMember(redis, memberId)
+          continue
+        }
+
+        // Skip if the member was hard-deleted (e.g., due to merge) after being queued.
+        // This prevents memberOrganizations foreign key (FK) violations from stale Redis entries.
+        const member = await findMemberById(qx, memberId, [MemberField.ID])
+
+        if (!member) {
+          ctx.log.warn({ memberId }, 'Member no longer exists, removing from queue.')
+
+          await purgeMember(redis, memberId)
           continue
         }
 
@@ -116,6 +129,15 @@ function parseSetMembers(members: string[]): MemberOrgDate[] {
   return results
 }
 
+/**
+ * Purges a member from the queue and their associated Redis entries.
+ */
+async function purgeMember(redis: RedisClient, memberId: string): Promise<void> {
+  const datesKey = `${MEMBER_ORG_STINT_CHANGES_DATES_PREFIX}:${memberId}`
+
+  await redis.multi().del(datesKey).sRem(MEMBER_ORG_STINT_CHANGES_QUEUE, memberId).exec()
+}
+
 /**
  * Applies the stint changes to the database.
  */