fix: resolve pr review comments

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

Author: skwowet

.github/scripts/public-api-e2e-tests.sh

@@ -56,9 +56,13 @@ die() {
   exit 1
 }
 
+CURL_CONNECT_TIMEOUT=10
+CURL_MAX_TIME=30
+
 api() {
   local method=$1 path=$2 body=${3-}
-  local -a args=(-sS -w '\n%{http_code}' -X "$method" "${CDP_API_E2E_BASE_URL}${path}"
+  local -a args=(-sS --connect-timeout "$CURL_CONNECT_TIMEOUT" --max-time "$CURL_MAX_TIME"
+    -w '\n%{http_code}' -X "$method" "${CDP_API_E2E_BASE_URL}${path}"
     -H 'Content-Type: application/json'
     -H "Authorization: Bearer ${TOKEN}")
   [[ -n $body ]] && args+=(-d "$body")
@@ -110,7 +114,8 @@ json() {
 
 fetch_token() {
   local response
-  response="$(curl -sS -X POST "${AUTH0_STAGING_ISSUER}/oauth/token" \
+  response="$(curl -sS --connect-timeout "$CURL_CONNECT_TIMEOUT" --max-time "$CURL_MAX_TIME" \
+    -X POST "${AUTH0_STAGING_ISSUER}/oauth/token" \
     -H 'Content-Type: application/json' \
     -d "$(json \
       --arg client_id "$AUTH0_API_E2E_CLIENT_ID" \

backend/src/api/public/openapi.yaml

@@ -855,7 +855,6 @@ paths:
                 - name
                 - domain
                 - source
-                - logo
               properties:
                 name:
                   type: string
@@ -872,7 +871,7 @@ paths:
                 logo:
                   type: string
                   format: uri
-                  description: URL of the organization's logo.
+                  description: Optional URL of the organization's logo.
             example:
               name: Acme Corp
               domain: acme.com

docs/adr/0012-api-e2e-test-architecture.md

@@ -65,7 +65,7 @@ flowchart LR
 4. Call endpoints and assert status + body
 5. Alert `#cdp-alerts` on failure
 
-`RUN_ID` is `GITHUB_RUN_ID` in Actions, otherwise timestamp + random. Fixtures include it so runs do not collide and leftovers stay easy to spot. The suite seeds over HTTP and does not require a wiped database between runs, only a reachable `api-e2e`.
+`RUN_ID` is `GITHUB_RUN_ID` (or a local timestamp) plus a `${RANDOM}` suffix. The suffix matters because workflow reruns reuse the same `GITHUB_RUN_ID`. Fixtures include it so runs do not collide and leftovers stay easy to spot. The suite seeds over HTTP and does not require a wiped database between runs, only a reachable `api-e2e`.
 
 ### What we assert (and what we do not)