fix: reject mailing list connect if already owned by another project (CM-1318)

Signed-off-by: Uroš Marolt <uros@marolt.me>

Author: themarolt

backend/src/services/integrationService.ts

@@ -16,7 +16,10 @@ import {
 } from '@crowd/common'
 import { CommonIntegrationService, getGithubInstallationToken } from '@crowd/common_services'
 import { ICreateInsightsProject } from '@crowd/data-access-layer/src/collections'
-import { upsertMailingLists } from '@crowd/data-access-layer/src/mailinglist'
+import {
+  findMailingListsOwnedByOtherIntegration,
+  upsertMailingLists,
+} from '@crowd/data-access-layer/src/mailinglist'
 import {
   ICreateRepository,
   IRepository,
@@ -1452,6 +1455,8 @@ export default class IntegrationService {
     let integration
 
     try {
+      const qx = SequelizeRepository.getQueryExecutor({ ...(options || this.options), transaction })
+
       integration = await this.createOrUpdate(
         {
           platform: PlatformType.MAILINGLIST,
@@ -1462,8 +1467,16 @@ export default class IntegrationService {
         options,
       )
 
+      const conflicts = await findMailingListsOwnedByOtherIntegration(qx, integration.id, lists)
+      if (conflicts.length > 0) {
+        throw new Error400(
+          this.options.language,
+          'errors.mailingList.alreadyConnected',
+          conflicts.join(', '),
+        )
+      }
+
       const currentSegmentId = (options || this.options).currentSegments[0].id
-      const qx = SequelizeRepository.getQueryExecutor({ ...(options || this.options), transaction })
       await upsertMailingLists(qx, currentSegmentId, integration.id, lists)
 
       if (!existingTransaction) {

services/libs/common/src/i18n/en.ts

@@ -182,6 +182,10 @@ const en = {
       invalidCredentials: 'Invalid email or password',
       invalid2FA: 'Invalid Two-factor authentication code',
     },
+    mailingList: {
+      alreadyConnected:
+        'The following mailing lists are already connected to another project: {0}',
+    },
     alreadyExists: '{0}',
     organization: {
       unmerge: {

services/libs/data-access-layer/src/mailinglist/index.ts

@@ -5,6 +5,42 @@ export interface IMailingListToOnboard {
   sourceUrl: string
 }
 
+/**
+ * Find sourceUrls already onboarded under a different, non-deleted
+ * integration. Used to reject a connect/update call before it silently
+ * re-points an already-owned list to the calling integration.
+ * @param qx - Query executor
+ * @param integrationId - Integration attempting to onboard `lists`
+ * @param lists - Mailing lists the caller wants to onboard
+ */
+export async function findMailingListsOwnedByOtherIntegration(
+  qx: QueryExecutor,
+  integrationId: string,
+  lists: IMailingListToOnboard[],
+): Promise<string[]> {
+  if (lists.length === 0) {
+    return []
+  }
+
+  const rows = await qx.select(
+    `
+    SELECT "sourceUrl"
+    FROM mailinglist.lists
+    WHERE "integrationId" != $(integrationId)::uuid
+      AND "deletedAt" IS NULL
+      AND "sourceUrl" IN (
+        SELECT v."sourceUrl" FROM json_to_recordset($(lists)::json) AS v(name text, "sourceUrl" text)
+      )
+    `,
+    {
+      integrationId,
+      lists: JSON.stringify(lists),
+    },
+  )
+
+  return rows.map((row: { sourceUrl: string }) => row.sourceUrl)
+}
+
 /**
  * Upsert mailing lists (public-inbox/lore) for a segment/integration and
  * seed their processing state so the mailing_list_integration worker picks