fix: address simple mailing list PR review comments (CM-1318)

Signed-off-by: Uroš Marolt <uros@marolt.me>

Author: themarolt

.github/workflows/backend-lint.yaml

@@ -102,6 +102,7 @@ jobs:
         if: steps.changes.outputs.python_changed == 'true'
         run: |
           uv run ruff check src/ --output-format=github
+          uv run ruff format --check src/
 
   lint-python-mailing-list-integration:
     runs-on: ubuntu-latest
@@ -146,6 +147,10 @@ jobs:
           uv run ruff check src/ --output-format=github
           uv run ruff format --check src/
 
+      - name: Run tests
+        if: steps.changes.outputs.python_changed == 'true'
+        run: uv run pytest src/test/ -v
+
       - name: Skip Python checks
         if: steps.changes.outputs.python_changed == 'false'
         run: echo "⏭️ No Python files changed, skipping linting checks"

backend/src/database/migrations/V1784291394__add_mailinglist_activity_type.sql

@@ -1,3 +1,3 @@
 -- Mailing list (Collaboration)
-INSERT INTO "activityTypes" ("activityType", platform, "isCodeContribution", "isCollaboration", description) VALUES
-('message', 'mailinglist', false, true, 'Sent a message to a mailing list');
+INSERT INTO "activityTypes" ("activityType", platform, "isCodeContribution", "isCollaboration", description, "label") VALUES
+('message', 'mailinglist', false, true, 'Sent a message to a mailing list', 'Sent a message');

services/apps/mailing_list_integration/README.md

@@ -13,7 +13,7 @@ tracker referenced in the PR for build progress.
   process, mirrors the list via `public-inbox-clone`/`public-inbox-fetch`,
   parses new messages, writes activities to `integration.results`, and emits
   Kafka messages to the `data-sink-worker` topic — same plumbing as
-  git_integration, with `platform=groupsio`.
+  git_integration, with `platform=mailinglist`.
 - `services/mirror/` wraps the external `public-inbox` CLI (Perl tool,
   installed system-wide, not vendored).
 - `services/parse/` is the ported email parser (originally `noteren.py`),
@@ -43,7 +43,7 @@ There is no UI yet — a list is onboarded by inserting its rows directly.
 psql "$CROWD_DB_WRITE_URI" -f dev/seed.sql
 ```
 
-It creates a `public.integrations` row (`platform='groupsio'`), a
+It creates a `public.integrations` row (`platform='mailinglist'`), a
 `mailinglist.lists` row pointing at an existing segment, and a
 `mailinglist."listProcessing"` row in state `pending` — which the worker's
 `acquire_onboarding_list()` will pick up on its next poll. Edit the `name`
@@ -59,17 +59,18 @@ and `"sourceUrl"` values in the file to onboard a different lore list.
    - inserts rows into `integration.results` with `state='pending'` and
      `data.type='activity'`,
    - emits one Kafka message per result (`process_integration_result`,
-     `platform=groupsio`),
+     `platform=mailinglist`),
    - advances `mailinglist."listProcessing"."lastProcessedHeads"` and sets
      `state='completed'`.
 4. Confirm `data_sink_worker` consumes the message, resolves the integration's
-   `platform='groupsio'`, and creates the member (email-based verified
+   `platform='mailinglist'`, and creates the member (email-based verified
    `username`+`email` identities) and activity.
 5. `GET http://localhost:8086/` returns the FastAPI health check.
 
 ## Out of scope (CM-1318)
 
-- Onboarding UI/backend to create `integrations` + `mailinglist.lists` rows
-  (this is what `dev/seed.sql` stands in for).
+- Onboarding UI to create `integrations` + `mailinglist.lists` rows (the
+  `mailing-list-connect` backend endpoint exists; `dev/seed.sql` remains
+  useful for onboarding lists without going through the UI).
 - Whether `member_join`/`member_leave` activities are derivable from lore, or
   only `message` initially.

services/apps/mailing_list_integration/src/crowdmail/server.py

@@ -24,12 +24,13 @@ async def lifespan(app: FastAPI) -> AsyncIterator[None]:
         yield
     finally:
         await worker.shutdown()  # stopping worker to process new lists
-        try:
-            await asyncio.wait_for(worker_task, timeout=WORKER_SHUTDOWN_TIMEOUT_SEC)
-            logger.info("Worker shutdown complete")
-        except TimeoutError:
-            logger.warning("Worker shutdown timeout, forcing cancellation")
-            worker_task.cancel()
+        if worker_task is not None:
+            try:
+                await asyncio.wait_for(worker_task, timeout=WORKER_SHUTDOWN_TIMEOUT_SEC)
+                logger.info("Worker shutdown complete")
+            except TimeoutError:
+                logger.warning("Worker shutdown timeout, forcing cancellation")
+                worker_task.cancel()
 
 
 app = FastAPI(lifespan=lifespan)

services/apps/mailing_list_integration/src/crowdmail/services/parse/noteren.py

@@ -20,6 +20,7 @@
 import sys
 
 from crowdmail.enums import ActivityType
+from crowdmail.errors import CommandExecutionError
 
 # We want to always be using utf-8
 email.charset.add_charset("utf-8", None)
@@ -68,8 +69,9 @@ def get_email_from_git(git_dir: str, git_id: str) -> tuple[bytes, str]:
         git_blob_id = out.decode().rstrip()  # strip the trailing \n
 
     if git_blob_id == "":
-        logging.error('git commit id %s was not found in the git repo "%s"', git_id, git_dir)
-        sys.exit(1)
+        msg = f'git commit id {git_id} was not found in the git repo "{git_dir}"'
+        logging.error(msg)
+        raise CommandExecutionError(msg)
 
     logging.debug("git_blob_id =%s", git_blob_id)
 
@@ -79,12 +81,9 @@ def get_email_from_git(git_dir: str, git_id: str) -> tuple[bytes, str]:
         # decoding itself, and decoding here would corrupt non-utf-8 parts.
         blob = out
     else:
-        logging.error(
-            'Unable to retrieve git blob %s from the git repo "%s"',
-            git_blob_id,
-            git_dir,
-        )
-        sys.exit(1)
+        msg = f'Unable to retrieve git blob {git_blob_id} from the git repo "{git_dir}"'
+        logging.error(msg)
+        raise CommandExecutionError(msg)
 
     return blob, git_blob_id
 
@@ -260,7 +259,7 @@ def parse_email(
                 # of emitting a malformed timestamp.
                 if not 1970 <= date_dt.year <= 9999:
                     raise ValueError(f"implausible year {date_dt.year}")
-                # add a fake set of microseconds just to make date parsers on the injest side happier
+                # add a fake set of microseconds just to make date parsers on the ingest side happier
                 date = date_dt.strftime("%Y-%m-%dT%H:%M:%S") + ".000000Z"
             except (ValueError, OverflowError):
                 logging.warning(

services/apps/mailing_list_integration/src/test/test_noteren.py

@@ -20,6 +20,7 @@
 
 import pytest
 
+from crowdmail.errors import CommandExecutionError
 from crowdmail.services.parse import noteren
 
 HERE = os.path.dirname(os.path.abspath(__file__))
@@ -247,20 +248,20 @@ def fake_git_run(git_dir, args, stdin=None):
     assert calls[1][1][0] == "cat-file"
 
 
-def test_get_email_from_git_missing_commit_exits(monkeypatch):
+def test_get_email_from_git_missing_commit_raises(monkeypatch):
     monkeypatch.setattr(noteren, "git_run_command", lambda *args, **kwargs: (0, b"", b""))
-    with pytest.raises(SystemExit):
+    with pytest.raises(CommandExecutionError):
         noteren.get_email_from_git("/tmp/repo.git", "deadbeef")
 
 
-def test_get_email_from_git_missing_blob_exits(monkeypatch):
+def test_get_email_from_git_missing_blob_raises(monkeypatch):
     def fake_git_run(git_dir, args, stdin=None):
         if args[0] == "ls-tree":
             return 0, b"blob123\n", b""
         return 1, b"", b"missing"
 
     monkeypatch.setattr(noteren, "git_run_command", fake_git_run)
-    with pytest.raises(SystemExit):
+    with pytest.raises(CommandExecutionError):
         noteren.get_email_from_git("/tmp/repo.git", "deadbeef")