fix: implement and trigger member cache invalidation after update ops [CM-823] (#3682)

Author: mbani01

backend/src/api/member/memberMerge.ts

@@ -1,5 +1,5 @@
 import { CommonMemberService } from '@crowd/common_services'
-import { optionsQx } from '@crowd/data-access-layer'
+import { MemberQueryCache, optionsQx } from '@crowd/data-access-layer'
 
 import Permissions from '../../security/permissions'
 import track from '../../segment/track'
@@ -12,6 +12,16 @@ export default async (req, res) => {
 
   const payload = await memberService.merge(req.params.memberId, req.body.memberToMerge, req)
 
+  // Invalidate member query cache after merge
+  try {
+    const cache = new MemberQueryCache(req.redis)
+    await cache.invalidateAll()
+    req.log.debug('Invalidated member query cache after merge')
+  } catch (error) {
+    // Don't fail the merge if cache invalidation fails
+    req.log.warn('Failed to invalidate member query cache after merge', { error })
+  }
+
   track(
     'Merge members',
     { memberId: req.params.memberId, memberToMergeId: req.body.memberToMerge },

backend/src/services/memberService.ts

@@ -10,6 +10,7 @@ import { CommonMemberService, getGithubInstallationToken } from '@crowd/common_s
 import { findMemberAffiliations } from '@crowd/data-access-layer/src/member_segment_affiliations'
 import {
   MemberField,
+  MemberQueryCache,
   addMemberRole,
   fetchManyMemberOrgsWithOrgData,
   fetchMemberBotSuggestionsBySegment,
@@ -67,6 +68,17 @@ import SettingsService from './settingsService'
 export default class MemberService extends LoggerBase {
   options: IServiceOptions
 
+  private async invalidateMemberQueryCache(): Promise<void> {
+    try {
+      const cache = new MemberQueryCache(this.options.redis)
+      await cache.invalidateAll()
+      this.log.debug('Invalidated member query cache')
+    } catch (error) {
+      // Don't fail the operation if cache invalidation fails
+      this.log.warn('Failed to invalidate member query cache', { error })
+    }
+  }
+
   constructor(options: IServiceOptions) {
     super(options.log)
     this.options = options
@@ -745,6 +757,9 @@ export default class MemberService extends LoggerBase {
           // trigger entity-merging-worker to move activities in the background
           await SequelizeRepository.commitTransaction(tx)
 
+          // Invalidate member query cache after unmerge
+          await this.invalidateMemberQueryCache()
+
           return { member, secondaryMember }
         }),
       )
@@ -1253,6 +1268,9 @@ export default class MemberService extends LoggerBase {
 
       await SequelizeRepository.commitTransaction(transaction)
 
+      // Invalidate member query cache after update
+      await this.invalidateMemberQueryCache()
+
       const commonMemberService = new CommonMemberService(
         optionsQx(this.options),
         this.options.temporal,
@@ -1304,6 +1322,9 @@ export default class MemberService extends LoggerBase {
       )
 
       await SequelizeRepository.commitTransaction(transaction)
+
+      // Invalidate member query cache after bulk delete
+      await this.invalidateMemberQueryCache()
     } catch (error) {
       await SequelizeRepository.rollbackTransaction(transaction)
       throw error

services/libs/data-access-layer/src/members/index.ts

@@ -7,3 +7,4 @@ export * from './attributes'
 export * from './dashboard'
 export * from './contributions'
 export * from './bot'
+export { MemberQueryCache } from './queryCache'

services/libs/data-access-layer/src/members/queryCache.ts

@@ -83,4 +83,18 @@ export class MemberQueryCache {
   async setCount(cacheKey: string, count: number, ttlSeconds: number): Promise<void> {
     await this.countCache.set(cacheKey, count.toString(), ttlSeconds)
   }
+
+  async invalidateAll(): Promise<void> {
+    try {
+      const [resultsDeleted, countsDeleted] = await Promise.all([
+        this.cache.deleteAll(),
+        this.countCache.deleteAll(),
+      ])
+      log.info(
+        `Invalidated member query cache: ${resultsDeleted} result entries, ${countsDeleted} count entries`,
+      )
+    } catch (error) {
+      log.warn('Error invalidating member query cache', { error })
+    }
+  }
 }