Skip to content

Commit ac7eee9

Browse files
committed
docs: fix stale comments after merge dedup + resume changes (CM-1296)
Signed-off-by: Uroš Marolt <uros@marolt.me>
1 parent a103b06 commit ac7eee9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

services/apps/packages_worker/src/deps-dev/queries/depsSql.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ SELECT
2222
FROM \`bigquery-public-data.deps_dev_v1.GoRequirementsLatest\` g,
2323
UNNEST(g.DirectDependencies) AS d`
2424

25-
// NuGet groups deps by TargetFramework — flatten all groups, dedup handled downstream
26-
// by ON CONFLICT in MERGE_SQL (and DISTINCT ON in the fill-constraints variant).
25+
// NuGet groups deps by TargetFramework — flatten all groups, duplicate (root, dep) pairs are
26+
// deduped downstream by DISTINCT ON + ON CONFLICT in MERGE_SQL (and the fill-constraints variant).
2727
const NUGET_FULL_PART = `
2828
SELECT
2929
'nuget' AS ecosystem,

services/libs/data-access-layer/src/osspckgs/ingestJobs.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ export async function findLatestExportedJobByKind(
8686
: null
8787
}
8888

89-
// Returns an existing exported job for the given GCS prefix so callers can
90-
// skip re-running the BQ export when retrying a failed workflow.
9189
// Loads the fields needed to resume a partially-merged chunked job by id: the exact GCS export
9290
// path (so the same parquet files — and therefore the same chunk boundaries — are re-listed) plus
9391
// the file-level load progress and rows-merged-so-far. progressDone/progressTotal come from the
@@ -139,6 +137,8 @@ export async function getIngestJobForResume(
139137
: null
140138
}
141139

140+
// Returns an existing exported job for the given GCS prefix so callers can
141+
// skip re-running the BQ export when retrying a failed workflow.
142142
export async function findExportedJobByGcsPrefix(
143143
qx: QueryExecutor,
144144
gcsPrefix: string,

0 commit comments

Comments
 (0)