Skip to content

Commit af3a4e5

Browse files
committed
fix: github repos enricher
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
1 parent 866f584 commit af3a4e5

4 files changed

Lines changed: 33 additions & 16 deletions

File tree

scripts/services/github-repos-enricher.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ x-env-args: &env-args
55
NODE_ENV: docker
66
SERVICE: github-repos-enricher
77
SHELL: /bin/sh
8+
SUPPRESS_NO_CONFIG_WARNING: 'true'
9+
PAGE_SIZE: '200'
10+
BATCH_SIZE: '50'
11+
MAX_RETRIES: '3'
12+
UPDATE_INTERVAL_HOURS: '24'
13+
IDLE_SLEEP_SEC: '60'
814

915
services:
1016
github-repos-enricher:
@@ -28,7 +34,7 @@ services:
2834
build:
2935
context: ../../
3036
dockerfile: ./scripts/services/docker/Dockerfile.packages-worker
31-
command: 'pnpm run dev:github-repos-enricher:local'
37+
command: 'pnpm run dev:github-repos-enricher'
3238
working_dir: /usr/crowd/app/services/apps/packages_worker
3339
# user: '${USER_ID}:${GROUP_ID}'
3440
env_file:

scripts/services/packages-worker.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ x-env-args: &env-args
55
NODE_ENV: docker
66
SERVICE: packages-worker
77
SHELL: /bin/sh
8+
SUPPRESS_NO_CONFIG_WARNING: 'true'
89

910
services:
1011
packages-worker:
@@ -28,7 +29,7 @@ services:
2829
build:
2930
context: ../../
3031
dockerfile: ./scripts/services/docker/Dockerfile.packages-worker
31-
command: 'pnpm run dev:packages-worker:local'
32+
command: 'pnpm run dev:packages-worker'
3233
working_dir: /usr/crowd/app/services/apps/packages_worker
3334
# user: '${USER_ID}:${GROUP_ID}'
3435
env_file:

services/apps/packages_worker/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
"scripts": {
55
"start:packages-worker": "SERVICE=packages-worker tsx src/bin/packages-worker.ts",
66
"start:github-repos-enricher": "SERVICE=github-repos-enricher tsx src/bin/github-repos-enricher.ts",
7-
"start:debug:packages-worker:local": "set -a && . ../../../backend/.env.dist.local && . ../../../backend/.env.override.local && set +a && SERVICE=packages-worker LOG_LEVEL=trace tsx --inspect=0.0.0.0:9233 src/bin/packages-worker.ts",
8-
"start:debug:github-repos-enricher:local": "set -a && . ../../../backend/.env.dist.local && . ../../../backend/.env.override.local && set +a && SERVICE=github-repos-enricher LOG_LEVEL=trace tsx --inspect=0.0.0.0:9234 src/bin/github-repos-enricher.ts",
9-
"dev:packages-worker:local": "nodemon --watch src --watch ../../libs --ext ts --exec pnpm run start:debug:packages-worker:local",
10-
"dev:github-repos-enricher:local": "nodemon --watch src --watch ../../libs --ext ts --exec pnpm run start:debug:github-repos-enricher:local",
7+
"dev:packages-worker": "SERVICE=packages-worker LOG_LEVEL=trace nodemon --watch src --watch ../../libs --ext ts --exec tsx --inspect=0.0.0.0:9233 src/bin/packages-worker.ts",
8+
"dev:github-repos-enricher": "SERVICE=github-repos-enricher LOG_LEVEL=trace nodemon --watch src --watch ../../libs --ext ts --exec tsx --inspect=0.0.0.0:9234 src/bin/github-repos-enricher.ts",
9+
"dev:packages-worker:local": "set -a && . ../../../backend/.env.dist.local && . ../../../backend/.env.override.local && set +a && SERVICE=packages-worker LOG_LEVEL=trace nodemon --watch src --watch ../../libs --ext ts --exec tsx --inspect=0.0.0.0:9233 src/bin/packages-worker.ts",
10+
"dev:github-repos-enricher:local": "set -a && . ../../../backend/.env.dist.local && . ../../../backend/.env.override.local && set +a && SERVICE=github-repos-enricher LOG_LEVEL=trace nodemon --watch src --watch ../../libs --ext ts --exec tsx --inspect=0.0.0.0:9234 src/bin/github-repos-enricher.ts",
1111
"lint": "npx eslint --ext .ts src --max-warnings=0",
1212
"format": "npx prettier --write \"src/**/*.ts\"",
1313
"format-check": "npx prettier --check .",
Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,20 @@
1+
function requireEnv(name: string): string {
2+
const val = process.env[name]
3+
if (!val) throw new Error(`Missing required environment variable: ${name}`)
4+
return val
5+
}
6+
7+
function requireEnvInt(name: string): number {
8+
return parseInt(requireEnv(name), 10)
9+
}
10+
111
export function getPackagesDbConfig() {
212
return {
3-
host: process.env.CROWD_PACKAGES_DB_WRITE_HOST,
4-
port: parseInt(process.env.CROWD_PACKAGES_DB_PORT, 10),
5-
database: process.env.CROWD_PACKAGES_DB_DATABASE,
6-
user: process.env.CROWD_PACKAGES_DB_USERNAME,
7-
password: process.env.CROWD_PACKAGES_DB_PASSWORD,
13+
host: requireEnv('CROWD_PACKAGES_DB_WRITE_HOST'),
14+
port: requireEnvInt('CROWD_PACKAGES_DB_PORT'),
15+
database: requireEnv('CROWD_PACKAGES_DB_DATABASE'),
16+
user: requireEnv('CROWD_PACKAGES_DB_USERNAME'),
17+
password: requireEnv('CROWD_PACKAGES_DB_PASSWORD'),
818
}
919
}
1020

@@ -14,10 +24,10 @@ export function getEnricherConfig() {
1424

1525
return {
1626
tokens,
17-
pageSize: parseInt(process.env.PAGE_SIZE, 10),
18-
batchSize: parseInt(process.env.BATCH_SIZE, 10),
19-
maxRetries: parseInt(process.env.MAX_RETRIES, 10),
20-
updateIntervalHours: parseInt(process.env.UPDATE_INTERVAL_HOURS, 10),
21-
idleSleepSec: parseInt(process.env.IDLE_SLEEP_SEC, 10),
27+
pageSize: requireEnvInt('PAGE_SIZE'),
28+
batchSize: requireEnvInt('BATCH_SIZE'),
29+
maxRetries: requireEnvInt('MAX_RETRIES'),
30+
updateIntervalHours: requireEnvInt('UPDATE_INTERVAL_HOURS'),
31+
idleSleepSec: requireEnvInt('IDLE_SLEEP_SEC'),
2232
}
2333
}

0 commit comments

Comments
 (0)