fix: nango worker bugfix (#3515)

Signed-off-by: Uroš Marolt <uros@marolt.me>

Author: themarolt

services/apps/nango_worker/src/activities/nangoActivities.ts

@@ -49,32 +49,38 @@ async function getLastConnectTs(): Promise<Date | undefined> {
 export async function numberOfGithubConnectionsToCreate(): Promise<number> {
   const max = Number(process.env.CROWD_MAX_GH_NANGO_CONNECTIONS_PER_HOUR || 1)
 
+  svc.log.info(`[GITHUB] Max number of github connections to create: ${max}`)
+
   if (IS_DEV_ENV || IS_STAGING_ENV) {
-    svc.log.info('Number of github connections to create: 5')
+    svc.log.info('[GITHUB] Number of github connections to create: 5')
     return 5
   }
 
   const lastConnectDate = await getLastConnectTs()
 
+  svc.log.info(`[GITHUB] Last connect date: ${lastConnectDate.toISOString()}`)
+
   if (!lastConnectDate) {
-    svc.log.info(`Number of github connections to create: ${max}`)
+    svc.log.info(`[GITHUB] Number of github connections to create: ${max}`)
     return max
   }
 
-  // we can allow max 10 per day so every 120 minutes (2 hours) we can connect 1
   const now = new Date()
+  svc.log.info(`[GITHUB] Now: ${now.toISOString()}`)
 
   // time is milliseconds
   const diff = now.getTime() - lastConnectDate.getTime()
 
   // how many hours
   const hours = diff / (1000 * 60 * 60) // ms to seconds to minutes
+  svc.log.info(`[GITHUB] Diff: ${diff}, hours: ${hours}`)
+
   if (hours >= 1.0) {
-    svc.log.info(`Number of github connections to create: ${max}`)
+    svc.log.info(`[GITHUB] Number of github connections to create: ${max}`)
     return max
   }
 
-  svc.log.info('Number of github connections to create: 0')
+  svc.log.info('[GITHUB] Number of github connections to create: 0')
   return 0
 }
 

services/apps/nango_worker/src/workflows/syncGithubIntegration.ts

@@ -8,6 +8,9 @@ const activity = proxyActivities<typeof activities>({
 })
 
 export async function syncGithubIntegration(args: ISyncGithubIntegrationArguments): Promise<void> {
+  const limit = await activity.numberOfGithubConnectionsToCreate()
+  let created = 0
+
   for (const integrationId of args.integrationIds) {
     const result = await activity.analyzeGithubIntegration(integrationId)
 
@@ -24,8 +27,6 @@ export async function syncGithubIntegration(args: ISyncGithubIntegrationArgument
     }
 
     // create connections for repos that are not already connected
-    const limit = await activity.numberOfGithubConnectionsToCreate()
-    let created = 0
     for (const repo of result.reposToSync) {
       if (created >= limit) {
         break