fix: percent-encode message-id in built activity url (CM-1318)

Signed-off-by: Uroš Marolt <uros@marolt.me>

Author: themarolt

services/apps/mailing_list_integration/src/crowdmail/services/parse/noteren.py

@@ -18,6 +18,7 @@
 import re
 import subprocess
 import sys
+import urllib.parse
 
 from crowdmail.enums import ActivityType
 from crowdmail.errors import CommandExecutionError
@@ -364,7 +365,7 @@ def parse_email(
         "channel": channel,
         "title": subject,
         "body": json_body,
-        "url": source.rstrip("/") + "/r/" + msgid,
+        "url": source.rstrip("/") + "/r/" + urllib.parse.quote(msgid, safe=""),
         "isContribution": True,
         "type": ActivityType.MESSAGE,
         # Matches groupsio's Groupsio_GRID MESSAGE score (services/libs/integrations/src/integrations/groupsio/grid.ts)

services/apps/mailing_list_integration/src/test/test_noteren.py

@@ -854,14 +854,14 @@ def test_parse_email_url_contains_message_id():
         b"body\n"
     )
     parsed = _parse_email(raw, "src", "chan", "c1", "b1")
-    assert parsed["activityData"]["url"] == "src/r/unique-id@example.com"
+    assert parsed["activityData"]["url"] == "src/r/unique-id%40example.com"
 
 
 def test_parse_email_url_with_no_message_id():
     """When Message-ID is absent the url must embed the synthetic channel:git_id id."""
     raw = b"From: A <a@example.com>\nSubject: s\nDate: Mon, 1 Jan 2024 12:00:00 +0000\n\nbody\n"
     parsed = _parse_email(raw, "src", "chan", "c1", "b1")
-    assert parsed["activityData"]["url"] == "src/r/chan:c1"
+    assert parsed["activityData"]["url"] == "src/r/chan%3Ac1"
 
 
 def test_parse_email_result_structure():