fix: correct guard alert wording + isScript doc for GO/NUGET/RUBYGEMS (CM-1241)

Signed-off-by: Uroš Marolt <uros@marolt.me>

Author: themarolt

services/apps/packages_worker/src/deps-dev/activities/checkDependentCountsGuard.ts

@@ -24,6 +24,16 @@ const GUARD_SOURCE_TABLE: Partial<Record<OsspckgsJobKind, string>> = {
   dependent_counts_rubygems: 'RubyGemsRequirementsLatest',
 }
 
+// `Dependents` is snapshotted per-date, so "for this snapshot date" is actionable there. The
+// GO/NUGET/RubyGems `*RequirementsLatest` views have no snapshot history (see bootstrapOsspckgs.ts,
+// RETENTION_DAYS_BY_KIND) — telling an operator to check "this snapshot date" on those is misleading.
+const GUARD_HAS_SNAPSHOT_HISTORY: Partial<Record<OsspckgsJobKind, boolean>> = {
+  dependent_counts: true,
+  dependent_counts_go: false,
+  dependent_counts_nuget: false,
+  dependent_counts_rubygems: false,
+}
+
 export interface CheckDependentCountsGuardOutput {
   ok: boolean
   prevRowCount: number | null
@@ -61,7 +71,7 @@ export async function checkDependentCountsGuard(
         },
         {
           title: 'Action',
-          text: `Ingest aborted — existing \`dependent_count\` values preserved. Check deps.dev \`${GUARD_SOURCE_TABLE[jobKind] ?? 'Dependents'}\` table for this snapshot date.`,
+          text: `Ingest aborted — existing \`dependent_count\` values preserved. Check deps.dev \`${GUARD_SOURCE_TABLE[jobKind] ?? 'Dependents'}\` table${(GUARD_HAS_SNAPSHOT_HISTORY[jobKind] ?? true) ? ' for this snapshot date' : ''}.`,
         },
       ],
     )

services/apps/packages_worker/src/deps-dev/workflows/ingestDependentCounts.ts

@@ -63,10 +63,11 @@ interface VariantConfig {
   pgColumns: string[]
   maxBytesGb: number
   buildSql: (snapshotDate: string) => string
-  // When true, buildSql returns a multi-statement BQ script (the GO/NUGET exact reverse transitive
-  // closure) that ends by creating TEMP TABLE _export_data, rather than a single SELECT. The export
-  // activity then appends only EXPORT DATA and enforces the byte ceiling via maximumBytesBilled
-  // instead of a dry-run. See ADR-0004. Unset (single-SELECT) for the edges variant; set for GO/NUGET.
+  // When true, buildSql returns a multi-statement BQ script (the GO/NUGET/RUBYGEMS exact reverse
+  // transitive closure) that ends by creating TEMP TABLE _export_data, rather than a single SELECT.
+  // The export activity then appends only EXPORT DATA and enforces the byte ceiling via
+  // maximumBytesBilled instead of a dry-run. See ADR-0004. Unset (single-SELECT) for the edges
+  // variant; set for GO/NUGET/RUBYGEMS.
   isScript?: boolean
 }